Created attachment 138180 [details] Screenshot of checkout history in mobile view on Firefox The checkout history table on mobile is large and there doesn't seem to be a way to scroll right. When on mobile, the current checkouts are not in a table, maybe the same could be done with the checkout history? To test: 1) Make sure you have checkouts in your account 2) Log into the OPAC --> In 'Your summary' current checkouts are in a table 3) Go to 'You checkout history' --> Current and previous checkouts are in a table 4) Switch to mobile view (in Firefox, Ctrl + Shift + M) --> Checkout history is still in a table and the last column is not entirely visible (depending on the content of the columns, I suppose) 5) Go to 'Your summary' --> Current checkouts are presented in list form instead of a table
I cannot reproduce this issue. Following your steps I'm able to scroll sideway with a trackpad (as this is a mobile view, scrolling with a touchscreen is possible). However I noticed that in the checkout history as well as in the summary the UI uses a table to display the data. So there's no list view for me.
You're right, I think I was testing on 22.05 (I'm documenting 22.05 and I can get a bit confused when I have 20 million tabs open and all the OPACs look the same, lol) In my current master (22.06.00.021), the checkouts table is a table and I can scroll sideways, and the checkout history is the same. In 22.05 (I'm at 22.05.02.001), the checkouts are in a list and the checkout history is in a table and I am unable to scroll. So we seem to have lost the checkouts in a list since 22.05, but we gained the scrolling. I'm not sure if it was intentional? Personally, I like the list form better on mobile. Opinions?
Caused by Bug 30570
Created attachment 144869 [details] [review] Bug 31248: Fix responsiveness of tables on OPAC summary page This patch adds back the responsive styles of the tables on the OPAC summary page. This includes all of the following tables that may appear: opac-user-checkouts opac-user-relative-issues opac-user-overdues opac-user-fines opac-user-relative-fines opac-user-clubs opac-user-holds opac-user-recalls opac-user-article-requests opac-user-overdrive opac-user-recordedbooks To test: 1) Make sure you have checkouts in your account 2) Log into the OPAC --> In 'Your summary' current checkouts are in a table 3) Go to 'You checkout history' --> Current and previous checkouts are in a table 4) Switch to mobile view (in Firefox, Ctrl + Shift + M) --> Checkout history is still in a table and the last column is not entirely visible (depending on the content of the columns, I suppose) 5) Go to 'Your summary' --> Current checkouts are presented in list form instead of a table 6) Apply patch and rebuild the OPAC CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 7) Try the tables again, they should appear in a list form when the screen is smaller than 608px.
Created attachment 144899 [details] [review] Bug 31248: Fix responsiveness of tables on OPAC summary page This patch adds back the responsive styles of the tables on the OPAC summary page. This includes all of the following tables that may appear: opac-user-checkouts opac-user-relative-issues opac-user-overdues opac-user-fines opac-user-relative-fines opac-user-clubs opac-user-holds opac-user-recalls opac-user-article-requests opac-user-overdrive opac-user-recordedbooks To test: 1) Make sure you have checkouts in your account 2) Log into the OPAC --> In 'Your summary' current checkouts are in a table 3) Go to 'You checkout history' --> Current and previous checkouts are in a table 4) Switch to mobile view (in Firefox, Ctrl + Shift + M) --> Checkout history is still in a table and the last column is not entirely visible (depending on the content of the columns, I suppose) 5) Go to 'Your summary' --> Current checkouts are presented in list form instead of a table 6) Apply patch and rebuild the OPAC CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 7) Try the tables again, they should appear in a list form when the screen is smaller than 608px. Signed-off-by: David Nind <david@davidnind.com>
Should I log a separate bug for the 'Checkout history' view (and maybe any others that need changing)? This still shows for me as a table and not a list, but is scrollable. Ideally, it should be as consistent as possible, and I agree with Caroline that the list view is easier to read on a mobile.
Created attachment 145375 [details] [review] Bug 31248: (follow-up) Add fix to checkout history page
(In reply to David Nind from comment #6) > Should I log a separate bug for the 'Checkout history' view (and maybe any > others that need changing)? This still shows for me as a table and not a > list, but is scrollable. > > Ideally, it should be as consistent as possible, and I agree with Caroline > that the list view is easier to read on a mobile. David, I provided a follow-up for the Checkout history table.
Created attachment 145376 [details] [review] Bug 31248: Fix responsiveness of tables on OPAC summary page This patch adds back the responsive styles of the tables on the OPAC summary page. This includes all of the following tables that may appear: opac-user-checkouts opac-user-relative-issues opac-user-overdues opac-user-fines opac-user-relative-fines opac-user-clubs opac-user-holds opac-user-recalls opac-user-article-requests opac-user-overdrive opac-user-recordedbooks To test: 1) Make sure you have checkouts in your account 2) Log into the OPAC --> In 'Your summary' current checkouts are in a table 3) Go to 'You checkout history' --> Current and previous checkouts are in a table 4) Switch to mobile view (in Firefox, Ctrl + Shift + M) --> Checkout history is still in a table and the last column is not entirely visible (depending on the content of the columns, I suppose) 5) Go to 'Your summary' --> Current checkouts are presented in list form instead of a table 6) Apply patch and rebuild the OPAC CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 7) Try the tables again, they should appear in a list form when the screen is smaller than 608px. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145377 [details] [review] Bug 31248: (follow-up) Add fix to checkout history page Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Tested with 2nd patch. Everything looks good!
Created attachment 147213 [details] [review] Bug 31248: Fix responsiveness of tables on OPAC summary page This patch adds back the responsive styles of the tables on the OPAC summary page. This includes all of the following tables that may appear: opac-user-checkouts opac-user-relative-issues opac-user-overdues opac-user-fines opac-user-relative-fines opac-user-clubs opac-user-holds opac-user-recalls opac-user-article-requests opac-user-overdrive opac-user-recordedbooks To test: 1) Make sure you have checkouts in your account 2) Log into the OPAC --> In 'Your summary' current checkouts are in a table 3) Go to 'You checkout history' --> Current and previous checkouts are in a table 4) Switch to mobile view (in Firefox, Ctrl + Shift + M) --> Checkout history is still in a table and the last column is not entirely visible (depending on the content of the columns, I suppose) 5) Go to 'Your summary' --> Current checkouts are presented in list form instead of a table 6) Apply patch and rebuild the OPAC CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 7) Try the tables again, they should appear in a list form when the screen is smaller than 608px. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 147214 [details] [review] Bug 31248: (follow-up) Add fix to checkout history page Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Seems like this one could be backported to 22.05? Yes/No?
Backported to 22.05.x for upcoming 22.05.11.
dependancy 30570 not met in 21.11, won't backport