On the patron edit view there is a "Clear" link to reset the value of an attribute. It does no longer work, nothing happens and no error in the console.
I think it is because we should use .val('') instead of .attr('value' , '').
Created attachment 138223 [details] [review] Bug 31251: Use jQuery val() to clear_entry 1. Add some patron attributes that are textarea and some that have an AV category so they are select dropdowns 2. Go to the patron form and add some values to the patron attributes 3. Use the "Clear" button to try and clear the values, doesnt work. 4. Apply patch 5. Try clearing values from patron attributes that are both select dropdowns and textarea. The "Clear" button should work.
Created attachment 138241 [details] [review] Bug 31251: Use jQuery val() to clear_entry 1. Add some patron attributes that are textarea and some that have an AV category so they are select dropdowns 2. Go to the patron form and add some values to the patron attributes 3. Use the "Clear" button to try and clear the values, doesnt work. 4. Apply patch 5. Try clearing values from patron attributes that are both select dropdowns and textarea. The "Clear" button should work. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 138392 [details] [review] Bug 31251: Use jQuery val() to clear_entry 1. Add some patron attributes that are textarea and some that have an AV category so they are select dropdowns 2. Go to the patron form and add some values to the patron attributes 3. Use the "Clear" button to try and clear the values, doesnt work. 4. Apply patch 5. Try clearing values from patron attributes that are both select dropdowns and textarea. The "Clear" button should work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.06
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.
Thanks! Pushed to 21.11 for 21.11.12