Bug 31138 made some DataTable errors much more visible, which is good. One that was noticed was when managing staged MARC files. To recreate: 1. Stage a MARC record for import 2. Once you have one click on 'Manage staged records' 3. You will see an alert that says "Something went wrong when loading the table." 4. If you dismiss that you should see the following error: DataTables warning: table id=records-table - Requested unknown parameter '' for row 0, column 4. For more information about this error, please see http://datatables.net/tn/4
Since columns 4 and 5 are later populated by jQuery 'sDefaultContent' should be used to define the placeholder value, I think.
Created attachment 138380 [details] [review] Bug 31269: Define sDefaultContent for DataTables 1. Stage a MARC record for import 2. Once you have one click on 'Manage staged records' 3. You will see an alert that says "Something went wrong when loading the table." 4. If you dismiss that you should see the following error: DataTables warning: table id=records-table - Requested unknown parameter '' for row 0, column 4. For more information about this error, please see http://datatables.net/tn/4 5. Appy patch 6. Try ssteps 1 & 2 again 7. No DataTable errors
Created attachment 138400 [details] [review] Bug 31269: Define sDefaultContent for DataTables 1. Stage a MARC record for import 2. Once you have one click on 'Manage staged records' 3. You will see an alert that says "Something went wrong when loading the table." 4. If you dismiss that you should see the following error: DataTables warning: table id=records-table - Requested unknown parameter '' for row 0, column 4. For more information about this error, please see http://datatables.net/tn/4 5. Appy patch 6. Try ssteps 1 & 2 again 7. No DataTable errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Please don't forget to fill in the assignee.
Created attachment 138451 [details] [review] Bug 31269: Define sDefaultContent for DataTables 1. Stage a MARC record for import 2. Once you have one click on 'Manage staged records' 3. You will see an alert that says "Something went wrong when loading the table." 4. If you dismiss that you should see the following error: DataTables warning: table id=records-table - Requested unknown parameter '' for row 0, column 4. For more information about this error, please see http://datatables.net/tn/4 5. Appy patch 6. Try ssteps 1 & 2 again 7. No DataTable errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.06
I don't reproduce the original issue on 21.11.x branch. Won't backport unless asked to.