See bug 30933 comment38.
Created attachment 138525 [details] [review] Bug 31288: (QA follow-up) Check userenv in disown_or_delete Test plan: Run t/db_dependent/Koha/Virtualshelves.t Set ListOwnershipUponPatronDeletion to change and leave pref ListOwnerDesignated empty. Run t/db_dependent/Koha/AdditionalContents.t * Without this patch, the test would fail in this context. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This patch can be viewed as a late QA follow-up for the RM follow-up ;)
Created attachment 138526 [details] [review] Bug 31288: (QA follow-up) Check userenv in disown_or_delete Test plan: Run t/db_dependent/Koha/Virtualshelves.t Set ListOwnershipUponPatronDeletion to change and leave pref ListOwnerDesignated empty. Run t/db_dependent/Koha/AdditionalContents.t * Without this patch, the test would fail in this context. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 138542 [details] [review] Bug 31288: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 138543 [details] [review] Bug 31288: (QA follow-up) Check userenv in disown_or_delete Test plan: 1. Apply the regression tests 2. Run: $ kshell k$ t/db_dependent/Koha/Virtualshelves.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Good catch, Marcel. Thanks for the patch.
Missing dependencies for 22.05.x, no backport