Bug 31318 - Remove GetItemsInfo from serials/routing-preview
Summary: Remove GetItemsInfo from serials/routing-preview
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 31306
Blocks: 31330 27272
  Show dependency treegraph
 
Reported: 2022-08-08 14:23 UTC by Jonathan Druart
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31318: Remove GetItemsInfo from serials/routing-preview (1.89 KB, patch)
2022-08-08 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31318: Remove GetItemsInfo from serials/routing-preview (1.93 KB, patch)
2022-08-09 12:35 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31318: Remove GetItemsInfo from serials/routing-preview (1.99 KB, patch)
2022-08-10 11:37 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-08-08 14:23:06 UTC
Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with serials/routing-preview
Comment 1 Jonathan Druart 2022-08-08 14:52:28 UTC
Created attachment 138828 [details] [review]
Bug 31318: Remove GetItemsInfo from serials/routing-preview

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with serials/routing-preview

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly
Comment 2 Owen Leonard 2022-08-09 12:35:17 UTC
Created attachment 138901 [details] [review]
Bug 31318: Remove GetItemsInfo from serials/routing-preview

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with serials/routing-preview

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2022-08-10 10:40:29 UTC
This code is actually broken, see bug 2894 and friends. I don't think we should block this patch because if this long standing bug.
Comment 4 Nick Clemens (kidclamp) 2022-08-10 11:37:23 UTC
Created attachment 138976 [details] [review]
Bug 31318: Remove GetItemsInfo from serials/routing-preview

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with serials/routing-preview

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2022-08-16 13:22:24 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!