Bug 31319 - Remove GetItemsInfo from tags/list.pl
Summary: Remove GetItemsInfo from tags/list.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 31306
Blocks: 27272
  Show dependency treegraph
 
Reported: 2022-08-08 14:23 UTC by Jonathan Druart
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31319: Remove GetItemsInfo from tags/list.pl (3.17 KB, patch)
2022-08-08 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31319: Remove GetItemsInfo from tags/list.pl (3.22 KB, patch)
2022-08-09 12:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31319: Remove GetItemsInfo from tags/list.pl (3.28 KB, patch)
2022-08-09 13:22 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31319: (QA follow-up) Search items directly (biblio not used yet) (1.02 KB, patch)
2022-08-09 13:22 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31319: (QA follow-up) Search items directly (biblio not used yet) (1.37 KB, patch)
2022-08-09 13:47 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-08-08 14:23:09 UTC
Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with tags/list.pl
Comment 1 Jonathan Druart 2022-08-08 14:52:48 UTC
Created attachment 138829 [details] [review]
Bug 31319: Remove GetItemsInfo from tags/list.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with tags/list

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly
Comment 2 Owen Leonard 2022-08-09 12:40:44 UTC
Created attachment 138902 [details] [review]
Bug 31319: Remove GetItemsInfo from tags/list.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with tags/list

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Nick Clemens 2022-08-09 13:22:09 UTC
Created attachment 138910 [details] [review]
Bug 31319: Remove GetItemsInfo from tags/list.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with tags/list

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens 2022-08-09 13:22:12 UTC
Created attachment 138911 [details] [review]
Bug 31319: (QA follow-up) Search items directly (biblio not used yet)

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Nick Clemens 2022-08-09 13:22:52 UTC
follow-up is debatable - more readable before, but we don't use the biblio data (yet) so intermediary object is not needed
Comment 6 Jonathan Druart 2022-08-09 13:39:07 UTC
testing something
Comment 7 Jonathan Druart 2022-08-09 13:45:20 UTC
I am getting a 500 with the second patch

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394

The biblio is linked to a subscription.
Comment 8 Jonathan Druart 2022-08-09 13:47:35 UTC
Created attachment 138914 [details] [review]
Bug 31319: (QA follow-up) Search items directly (biblio not used yet)

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

JD amended patch: add 'me' prefix to prevent failure if biblio is linked
with a subscription
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Tomás Cohen Arazi 2022-08-09 15:06:24 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!