Bug 31335 - Unnecessary holds fetch in serials/routing-preview.pl
Summary: Unnecessary holds fetch in serials/routing-preview.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-10 10:33 UTC by Jonathan Druart
Modified: 2024-07-04 18:41 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:


Attachments
Bug 31335: Remove unnecessary holds fetch from routing-preview (1.13 KB, patch)
2022-08-10 10:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31335: Remove unnecessary holds fetch from routing-preview (1.20 KB, patch)
2024-03-20 12:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31335: Remove unnecessary holds fetch from routing-preview (1.26 KB, patch)
2024-04-10 09:54 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-08-10 10:33:25 UTC
The following code is not needed.
        my $holds = $biblio->current_holds;
        my $count = $holds->count;
        while ( my $hold = $holds->next ) {
            $count-- if $hold->is_waiting;
        }
Comment 1 Jonathan Druart 2022-08-10 10:35:29 UTC
Created attachment 138970 [details] [review]
Bug 31335: Remove unnecessary holds fetch from routing-preview

This $count variable is not used later, and I didn't find why it was
there in previous versions.

Test plan:
Use `git log -p serials/routing-preview.pl` and confirm we can remove
this block
Comment 2 Owen Leonard 2024-03-20 12:59:43 UTC
Created attachment 163525 [details] [review]
Bug 31335: Remove unnecessary holds fetch from routing-preview

This $count variable is not used later, and I didn't find why it was
there in previous versions.

Test plan:
Use `git log -p serials/routing-preview.pl` and confirm we can remove
this block

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2024-04-10 09:54:08 UTC
Created attachment 164594 [details] [review]
Bug 31335: Remove unnecessary holds fetch from routing-preview

This $count variable is not used later, and I didn't find why it was
there in previous versions.

Test plan:
Use `git log -p serials/routing-preview.pl` and confirm we can remove
this block

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-04-10 09:54:24 UTC
Trivial clear fix, Passing QA
Comment 5 Jonathan Druart 2024-04-15 15:19:36 UTC
(In reply to Martin Renvoize from comment #4)
> Trivial clear fix, Passing QA

But took 1.5 year :D
Comment 6 Katrin Fischer 2024-04-26 16:06:57 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-24 08:52:45 UTC
Not backported to 23.11.x
Comment 8 Caroline Cyr La Rose 2024-07-04 18:41:15 UTC
Architecture change, nothing to add/edit in the Koha manual.