The following code is not needed. my $holds = $biblio->current_holds; my $count = $holds->count; while ( my $hold = $holds->next ) { $count-- if $hold->is_waiting; }
Created attachment 138970 [details] [review] Bug 31335: Remove unnecessary holds fetch from routing-preview This $count variable is not used later, and I didn't find why it was there in previous versions. Test plan: Use `git log -p serials/routing-preview.pl` and confirm we can remove this block
Created attachment 163525 [details] [review] Bug 31335: Remove unnecessary holds fetch from routing-preview This $count variable is not used later, and I didn't find why it was there in previous versions. Test plan: Use `git log -p serials/routing-preview.pl` and confirm we can remove this block Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 164594 [details] [review] Bug 31335: Remove unnecessary holds fetch from routing-preview This $count variable is not used later, and I didn't find why it was there in previous versions. Test plan: Use `git log -p serials/routing-preview.pl` and confirm we can remove this block Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial clear fix, Passing QA
(In reply to Martin Renvoize from comment #4) > Trivial clear fix, Passing QA But took 1.5 year :D
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x
Architecture change, nothing to add/edit in the Koha manual.