To recreate: 1. Have some waiting holds 2. Go to waitingreserves.tt 3. The table loads but notice the 'cancel_selected_holds' button is an empty button. 4. Look at the console and notice the "Uncaught TypeError: settings is null" error.
This is caused by Bug 31138. I don't think I understand why that change was made.
(In reply to Owen Leonard from comment #1) > This is caused by Bug 31138. I don't think I understand why that change was > made. To catch errors or mistakes, see bug 31138 comment 0. It is more obvious when you have an error server-side: the table was empty with nothing to tell the user that something wrong happened.
Created attachment 139048 [details] [review] Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden
Created attachment 139049 [details] [review] Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither.
(In reply to Jonathan Druart from comment #2) > (In reply to Owen Leonard from comment #1) > > This is caused by Bug 31138. I don't think I understand why that change was > > made. > > To catch errors or mistakes, see bug 31138 comment 0. > It is more obvious when you have an error server-side: the table was empty > with nothing to tell the user that something wrong happened. And here it caught a mistake ;)
First patch is a follow-up of bug 31138, second patch is a follow-up of bug 22456.
Created attachment 139053 [details] [review] Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 139054 [details] [review] Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 139499 [details] [review] Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 139500 [details] [review] Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Missing 22.05.x dependencies, no backport