Bug 31343 - DataTables error on waitingreserves.tt
Summary: DataTables error on waitingreserves.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 22456 31138
Blocks:
  Show dependency treegraph
 
Reported: 2022-08-11 17:57 UTC by Lucas Gass
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31343: (bug 31138 follow-up) Don't hide error (1.10 KB, patch)
2022-08-12 13:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31343: Prevent two nodes #holdscr on waiting reserves (1.68 KB, patch)
2022-08-12 13:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31343: (bug 31138 follow-up) Don't hide error (1.15 KB, patch)
2022-08-12 13:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31343: Prevent two nodes #holdscr on waiting reserves (1.73 KB, patch)
2022-08-12 13:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31343: (bug 31138 follow-up) Don't hide error (1.20 KB, patch)
2022-08-19 14:39 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 31343: Prevent two nodes #holdscr on waiting reserves (1.78 KB, patch)
2022-08-19 14:39 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-08-11 17:57:09 UTC
To recreate:

1. Have some waiting holds
2. Go to waitingreserves.tt
3. The table loads but notice the 'cancel_selected_holds' button is an empty button.
4. Look at the console and notice the "Uncaught TypeError: settings is null" error.
Comment 1 Owen Leonard 2022-08-12 11:57:13 UTC
This is caused by Bug 31138. I don't think I understand why that change was made.
Comment 2 Jonathan Druart 2022-08-12 13:10:17 UTC
(In reply to Owen Leonard from comment #1)
> This is caused by Bug 31138. I don't think I understand why that change was
> made.

To catch errors or mistakes, see bug 31138 comment 0.
It is more obvious when you have an error server-side: the table was empty with nothing to tell the user that something wrong happened.
Comment 3 Jonathan Druart 2022-08-12 13:20:25 UTC
Created attachment 139048 [details] [review]
Bug 31343: (bug 31138 follow-up) Don't hide error

Some errors are not passing settings and so the error is hidden
Comment 4 Jonathan Druart 2022-08-12 13:20:29 UTC
Created attachment 139049 [details] [review]
Bug 31343: Prevent two nodes #holdscr on waiting reserves

Two nodes with id="holdscr" existed on this patch. I guess the table was
not initiated properly before 31138 neither.
Comment 5 Jonathan Druart 2022-08-12 13:20:57 UTC
(In reply to Jonathan Druart from comment #2)
> (In reply to Owen Leonard from comment #1)
> > This is caused by Bug 31138. I don't think I understand why that change was
> > made.
> 
> To catch errors or mistakes, see bug 31138 comment 0.
> It is more obvious when you have an error server-side: the table was empty
> with nothing to tell the user that something wrong happened.

And here it caught a mistake ;)
Comment 6 Jonathan Druart 2022-08-12 13:22:12 UTC
First patch is a follow-up of bug 31138, second patch is a follow-up of bug 22456.
Comment 7 Owen Leonard 2022-08-12 13:43:40 UTC
Created attachment 139053 [details] [review]
Bug 31343: (bug 31138 follow-up) Don't hide error

Some errors are not passing settings and so the error is hidden

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 8 Owen Leonard 2022-08-12 13:43:44 UTC
Created attachment 139054 [details] [review]
Bug 31343: Prevent two nodes #holdscr on waiting reserves

Two nodes with id="holdscr" existed on this patch. I guess the table
was not initiated properly before 31138 neither.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Tomás Cohen Arazi 2022-08-19 14:39:28 UTC
Created attachment 139499 [details] [review]
Bug 31343: (bug 31138 follow-up) Don't hide error

Some errors are not passing settings and so the error is hidden

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 10 Tomás Cohen Arazi 2022-08-19 14:39:44 UTC
Created attachment 139500 [details] [review]
Bug 31343: Prevent two nodes #holdscr on waiting reserves

Two nodes with id="holdscr" existed on this patch. I guess the table
was not initiated properly before 31138 neither.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 11 Tomás Cohen Arazi 2022-08-19 19:05:14 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 12 Lucas Gass 2022-10-14 19:23:31 UTC
Missing 22.05.x dependencies, no backport