I was made aware of a problem with some Syndetics images not appearing properly on the OPAC detail page. On closer inspection I noticesd some of the links include '&' or two encoded &'s. Also, the filters are html when I think they should be uri when they are part of a URL query string.
Created attachment 139032 [details] [review] Bug 31346: Fix broken Syndetics links on OPAC detail page To test: -Have some Syndetics credentials -Turn on SyndeticsCoverImages -Look at some and you'll notice that Syndetics cover images dont always load -If you view the page source you'll see why. The links are built like this: https://secure.syndetics.com/index.aspx?isbn=/LC.GIF&client=bedf&type=xw10&upc=843501038123&oclc=1311289389 -Apply patch -Cover images should load properly.
Created attachment 139059 [details] [review] Bug 31346: Fix broken Syndetics links on OPAC detail page To test: -Have some Syndetics credentials -Turn on SyndeticsCoverImages -Look at some and you'll notice that Syndetics cover images dont always load -If you view the page source you'll see why. The links are built like this: https://secure.syndetics.com/index.aspx?isbn=/LC.GIF&amp;client=bedf&type=xw10&upc=843501038123&oclc=1311289389 -Apply patch -Cover images should load properly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Worked great! Cover images now display like they are supposed to.
Created attachment 139060 [details] [review] Bug 31346: Fix broken Syndetics links on OPAC detail page To test: -Have some Syndetics credentials -Turn on SyndeticsCoverImages -Look at some and you'll notice that Syndetics cover images dont always load -If you view the page source you'll see why. The links are built like this: https://secure.syndetics.com/index.aspx?isbn=/LC.GIF&amp;client=bedf&type=xw10&upc=843501038123&oclc=1311289389 -Apply patch -Cover images should load properly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Verified the code changes as I couldn't test with Syndetics, trusting that Lucas and Barbara took care of that :)
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.06
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.
Thanks! Pushed to 21.11 for 21.11.12