Bug 31399 - Set focus for cursor to first input field when adding new classification source, filing rule, or splitting rule
Summary: Set focus for cursor to first input field when adding new classification sour...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks: 31411
  Show dependency treegraph
 
Reported: 2022-08-18 20:46 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement sets the cursor/focus on the first form field when adding an entry on the classification configuration page (includes input forms for new classification source, filing rule, and splitting rule).
Version(s) released in:
22.11.00


Attachments
Bug 31399: Set focus on first input when adding a new classification source, filing rule, or splitting rule (4.02 KB, patch)
2022-08-18 20:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31399: Set focus on first input when adding a new classification source, filing rule, or splitting rule (4.06 KB, patch)
2022-08-18 21:00 UTC, David Nind
Details | Diff | Splinter Review
Bug 31399: Set focus on first input when adding a new classification source, filing rule, or splitting rule (4.12 KB, patch)
2022-09-02 14:34 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-08-18 20:46:29 UTC

    
Comment 1 Katrin Fischer 2022-08-18 20:52:02 UTC
Created attachment 139428 [details] [review]
Bug 31399: Set focus on first input when adding a new classification source, filing rule, or splitting rule

This makes sure the cursor/focus is always in the first form
field when adding an entry on the classification configuration page.

* Got to administration > classification sources
* Verify for each of the three "New ..." buttons on top that
  the entry form has no focus on any field
* Apply patch
* Repeat testing the new forms and the focus now should always
  be in the first input field of the entry form
Comment 2 David Nind 2022-08-18 21:00:12 UTC
Created attachment 139430 [details] [review]
Bug 31399: Set focus on first input when adding a new classification source, filing rule, or splitting rule

This makes sure the cursor/focus is always in the first form
field when adding an entry on the classification configuration page.

* Got to administration > classification sources
* Verify for each of the three "New ..." buttons on top that
  the entry form has no focus on any field
* Apply patch
* Repeat testing the new forms and the focus now should always
  be in the first input field of the entry form

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Kyle M Hall 2022-09-02 14:34:34 UTC
Created attachment 140155 [details] [review]
Bug 31399: Set focus on first input when adding a new classification source, filing rule, or splitting rule

This makes sure the cursor/focus is always in the first form
field when adding an entry on the classification configuration page.

* Got to administration > classification sources
* Verify for each of the three "New ..." buttons on top that
  the entry form has no focus on any field
* Apply patch
* Repeat testing the new forms and the focus now should always
  be in the first input field of the entry form

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2022-09-07 20:46:28 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!