There are some discrepancies between the circuation sidebar (activated by CircSidebar) and the circulation start page: * Headings don't match up: Holds, transfers and overdues are missing * Transfer needs to be moved under transfers heading * Transfers to send is missing
Created attachment 140006 [details] [review] Bug 31404: Sync Circulation sidebar with Circulation home This patch syncs the content of the circulation sidebar navigation with the content of the circulation homepage Test plan 1. Enable the `CircSidebar` system preference 2. Compare the sidebar navigation on circulation pages with the content of the circulation homepage.
Created attachment 140167 [details] [review] Bug 31404: Sync Circulation sidebar with Circulation home This patch syncs the content of the circulation sidebar navigation with the content of the circulation homepage Test plan 1. Enable the `CircSidebar` system preference 2. Compare the sidebar navigation on circulation pages with the content of the circulation homepage. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 140278 [details] [review] Bug 31404: Sync Circulation sidebar with Circulation home This patch syncs the content of the circulation sidebar navigation with the content of the circulation homepage Test plan 1. Enable the `CircSidebar` system preference 2. Compare the sidebar navigation on circulation pages with the content of the circulation homepage. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 140279 [details] [review] Bug 31404: (QA follow-up) Mostly whitespace fixes * Removed the leading space from the new entries as this could lead to another string to translate and they are not needed * Removed some doubled up whitespaces from the <a> tags and a stray - * Removed title from Article requests since it was the same text as the link itself, not adding information Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice clean-up, thx Isobel! I have provided a small follow-up fixing some whitespace issues. I know spaces don't seem so important, but in programming one character often can make a big difference. In this case I was worried it might affect translations. We have to translate every string in Koha and often the only difference between 'the same' string might be a leading or trailing space, capitalization etc. Please keep the patches coming!
Pushed to master for 22.11. Nice work everyone, thanks!
Doesn't apply cleanly to 22.05.x so it will not be included in the 22.05.x series