Bug 31404 - Update circulation sidebar to match circulation start page
Summary: Update circulation sidebar to match circulation start page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Isobel Graham
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-08-18 21:46 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31404: Sync Circulation sidebar with Circulation home (9.10 KB, patch)
2022-08-31 15:16 UTC, Isobel Graham
Details | Diff | Splinter Review
Bug 31404: Sync Circulation sidebar with Circulation home (9.15 KB, patch)
2022-09-02 16:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31404: Sync Circulation sidebar with Circulation home (9.21 KB, patch)
2022-09-07 12:41 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31404: (QA follow-up) Mostly whitespace fixes (6.97 KB, patch)
2022-09-07 12:41 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-08-18 21:46:37 UTC
There are some discrepancies between the circuation sidebar (activated by CircSidebar) and the circulation start page:

* Headings don't match up: Holds, transfers and overdues are missing
* Transfer needs to be moved under transfers heading
* Transfers to send is missing
Comment 1 Isobel Graham 2022-08-31 15:16:23 UTC
Created attachment 140006 [details] [review]
Bug 31404: Sync Circulation sidebar with Circulation home

This patch syncs the content of the circulation sidebar navigation with
the content of the circulation homepage

Test plan
1. Enable the `CircSidebar` system preference
2. Compare the sidebar navigation on circulation pages with the content
   of the circulation homepage.
Comment 2 Owen Leonard 2022-09-02 16:25:38 UTC
Created attachment 140167 [details] [review]
Bug 31404: Sync Circulation sidebar with Circulation home

This patch syncs the content of the circulation sidebar navigation with
the content of the circulation homepage

Test plan
1. Enable the `CircSidebar` system preference
2. Compare the sidebar navigation on circulation pages with the content
   of the circulation homepage.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2022-09-07 12:41:14 UTC
Created attachment 140278 [details] [review]
Bug 31404: Sync Circulation sidebar with Circulation home

This patch syncs the content of the circulation sidebar navigation with
the content of the circulation homepage

Test plan
1. Enable the `CircSidebar` system preference
2. Compare the sidebar navigation on circulation pages with the content
   of the circulation homepage.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-09-07 12:41:18 UTC
Created attachment 140279 [details] [review]
Bug 31404: (QA follow-up) Mostly whitespace fixes

* Removed the leading space from the new entries as this could
  lead to another string to translate and they are not needed
* Removed some doubled up whitespaces from the <a> tags and
  a stray -
* Removed title from Article requests since it was the same text
  as the link itself, not adding information

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-09-07 12:46:21 UTC
Nice clean-up, thx Isobel! 

I have provided a small follow-up fixing some whitespace issues. I know spaces don't seem so important, but in programming one character often can make a big difference. In this case I was worried it might affect translations. We have to translate every string in Koha and often the only difference between 'the same' string might be a leading or trailing space, capitalization etc. 

Please keep the patches coming!
Comment 6 Tomás Cohen Arazi 2022-09-07 20:30:48 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-10-31 19:42:29 UTC
Doesn't apply cleanly to 22.05.x so it will not be included in the 22.05.x series