When adding a new OAI set from administration, the focus/cursor should be in the first field of the entry form: setSpec
Created attachment 146177 [details] [review] Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field
Created attachment 146267 [details] [review] Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field Signed-off-by: Owen Leonard <oleonard@myacpl.org>
In other places we only set the focus when adding and but when editing? Should we do that here to? See Bug 31410.
Created attachment 150133 [details] [review] dBug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Lucas Gass from comment #3) > In other places we only set the focus when adding and but when editing? > Should we do that here to? > > See Bug 31410. I changed the patch to not set the focus on the description when an existing set is edited. This is to avoid accidental changes and matches behavior on other pages, as Lucas has pointed out.
Created attachment 150134 [details] [review] Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
Comment on attachment 150133 [details] [review] dBug 31405: Set focus for cursor to setSpec input when adding a new OAI set Managed to double up the patches as I amended the patch title - from "dBug 31405: ..." to "Bug 31405: ...".
Created attachment 150397 [details] [review] Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.14.
Backported to 21.11.x for upcoming 21.11.22