Bug 31420 - Managing funds: Labels of statistic fields overlap with pull downs
Summary: Managing funds: Labels of statistic fields overlap with pull downs
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-19 14:44 UTC by Katrin Fischer
Modified: 2023-08-28 10:43 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15


Attachments
Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs (2.35 KB, patch)
2022-10-04 12:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs (2.41 KB, patch)
2022-10-05 20:34 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs (2.51 KB, patch)
2022-10-07 06:21 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-08-19 14:44:39 UTC
In the English templates some labels overlap with the input fields on the fund entry/edit form. These are:

* Statistic 1 done on:
* Statistic 2 done on:

In general we see a lot of these issues in translated templates as well. Could we standardize on a wider area for labels or make it more flexible?
Comment 1 Owen Leonard 2022-10-04 12:45:19 UTC
Created attachment 141303 [details] [review]
Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs

This patch removes some very old inline style attributes from the fund
edit form. The "white-space" attribute prevented label text from
naturally wrapping.

To test, apply the patch and go to Administration -> Funds.

- In the list of funds, click Actions -> Edit.
- The the form, confirm that the text of the "Statistic" 1 and 2 labels
  wraps, not getting hidden by the associated select tags.
Comment 2 PTFS Europe Sandboxes 2022-10-05 20:34:16 UTC
Created attachment 141404 [details] [review]
Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs

This patch removes some very old inline style attributes from the fund
edit form. The "white-space" attribute prevented label text from
naturally wrapping.

To test, apply the patch and go to Administration -> Funds.

- In the list of funds, click Actions -> Edit.
- The the form, confirm that the text of the "Statistic" 1 and 2 labels
  wraps, not getting hidden by the associated select tags.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Marcel de Rooy 2022-10-07 06:21:46 UTC
Created attachment 141477 [details] [review]
Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs

This patch removes some very old inline style attributes from the fund
edit form. The "white-space" attribute prevented label text from
naturally wrapping.

To test, apply the patch and go to Administration -> Funds.

- In the list of funds, click Actions -> Edit.
- The the form, confirm that the text of the "Statistic" 1 and 2 labels
  wraps, not getting hidden by the associated select tags.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2022-10-11 13:23:35 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-12-05 18:13:25 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 6 Arthur Suzuki 2022-12-14 14:32:06 UTC
applied to 21.11 for 21.11.15
Comment 7 wainuiwitikapark 2023-03-15 00:51:25 UTC
Not backported to 21.05.x