As we now have nice mappings for these in the tables, we should make also sure hat they are visible in the cataloguing editor by default in new installations.
Created attachment 146916 [details] [review] Bug 31432: Make 245$n$p visible by default in frameworks $n (part_number) and $p (part_name) now have their own columns in the database, but we are still hiding them by default. It woudl ease testing and cataloguig if we changed them to be visible by default in new installations. To test: * Check that in your current frameworks when adding a new record, 245 n and p are hidden * Apply the patch and start over: drop your db and run the web installer * Verify that the fields are now visible
Created attachment 146918 [details] [review] Bug 31432: Make 245$n$p visible by default in frameworks $n (part_number) and $p (part_name) now have their own columns in the database, but we are still hiding them by default. It woudl ease testing and cataloguig if we changed them to be visible by default in new installations. To test: * Check that in your current frameworks when adding a new record, 245 n and p are hidden * Apply the patch and start over: drop your db and run the web installer * Verify that the fields are now visible Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Please explain why you add the third occurrence to hidden=9 ? Close to 0 on the keyboard, haha? - hidden: -6 + hidden: 9
You are right... typo.
- tagfield: "246" tagsubfield: "n" liblibrarian: "Number of part/section of a work" libopac: "Number of part/section of a work" repeatable: 1 mandatory: 0 kohafield: "" tab: 2 authorised_value: "" authtypecode: "" value_builder: "" isurl: hidden: 9 frameworkcode: "" seealso: "" link: "" defaultvalue: - tagfield: "246" tagsubfield: "p" liblibrarian: "Name of part/section of a work" libopac: "Name of part/section of a work" repeatable: 1 mandatory: 0 kohafield: "" tab: 2 authorised_value: "" authtypecode: "" value_builder: "" isurl: hidden: -6 frameworkcode: "" seealso: "" link: "" I am seeing now that you change field 246. You are out of scope? Or change title and what about 246$p ?
Created attachment 149717 [details] [review] Bug 31432: Make 245$n$p visible by default in frameworks $n (part_number) and $p (part_name) now have their own columns in the database, but we are still hiding them by default. It woudl ease testing and cataloguig if we changed them to be visible by default in new installations. To test: * Check that in your current frameworks when adding a new record, 245 n and p are hidden * Apply the patch and start over: drop your db and run the web installer * Verify that the fields are now visible Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Thx Marcel, good catch.
Created attachment 149752 [details] [review] Bug 31432: Make 245$n$p visible by default in frameworks $n (part_number) and $p (part_name) now have their own columns in the database, but we are still hiding them by default. It woudl ease testing and cataloguig if we changed them to be visible by default in new installations. To test: * Check that in your current frameworks when adding a new record, 245 n and p are hidden * Apply the patch and start over: drop your db and run the web installer * Verify that the fields are now visible Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.13
applied to 21.11 for 21.11.21