Bug 31439 - Item count bullet (•) should be easier to style/remove
Summary: Item count bullet (•) should be easier to style/remove
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Lucas Gass
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-22 16:12 UTC by Lucas Gass
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31439: Use pseudo element for bullet in results.tt (2.40 KB, patch)
2022-09-01 18:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31439: Use pseudo element for bullet in results.tt (2.46 KB, patch)
2022-09-02 12:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31439: Use pseudo element for bullet in results.tt (2.53 KB, patch)
2022-09-12 16:55 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-08-22 16:12:12 UTC
The staff results page included a bullet (•) that is hard to target. It should be either wrapped in a class or a CSS psuedo element to make it easier to style of remove.
Comment 1 Lucas Gass 2022-09-01 18:14:30 UTC
Created attachment 140058 [details] [review]
Bug 31439: Use pseudo element for bullet in results.tt

To test:
1. Apply patch and regenerate CSS. See: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
2. Go to the staff results page and inscept the result_item_details class.
3. It should contain a ::before pseudo element that is the bullet point.
4. This is easier to remove of alter with the following CSS in IntraNetUSerCSS:

.result_item_details::before {
	content: " " !important;
}
Comment 2 Owen Leonard 2022-09-02 12:32:53 UTC
Created attachment 140113 [details] [review]
Bug 31439: Use pseudo element for bullet in results.tt

To test:
1. Apply patch and regenerate CSS. See:
  https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
2. Go to the staff results page and inscept the result_item_details
   class.
3. It should contain a ::before pseudo element that is the bullet point.
4. This is easier to remove of alter with the following CSS in
   IntraNetUSerCSS:

.result_item_details::before {
	content: " " !important;
}

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2022-09-12 16:55:29 UTC
Created attachment 140484 [details] [review]
Bug 31439: Use pseudo element for bullet in results.tt

To test:
1. Apply patch and regenerate CSS. See:
  https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
2. Go to the staff results page and inscept the result_item_details
   class.
3. It should contain a ::before pseudo element that is the bullet point.
4. This is easier to remove of alter with the following CSS in
   IntraNetUSerCSS:

.result_item_details::before {
	content: " " !important;
}

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-09-12 16:55:53 UTC
Perfec', Passing QA
Comment 5 Tomás Cohen Arazi 2022-09-12 18:37:13 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!