When you print a receipt slip in SCO, the library/branch you are at in should be fetched from the logged in staff member's data (staff login done before entering SCO view) instead of the patron's own who has signed in to the SCO. Printing a slip shows patron's own home branch in the slip as the branch they're in. This causes confusion with patrons who want to print receipts/slips.
Created attachment 140003 [details] [review] use staff id:s branch for sco printslip To test: Make sure the staff id's branch (used to login into SCO patron view) is not the same as the patron's who is logging into SCO. Print a slip in SCO and notice patron's own branch in the slip. Add patch. Print a slip and notice the branch is now the staff id:s branch used to sign in to SCO patron view.
Created attachment 140031 [details] [review] Bug 31496: Fix branch in printslip.pl to signed in staff id's branch Test plan: 1) Make sure the staff id's branch (used to login into SCO patron view) is not the same as the patron's who is logging into SCO 2) Print a slip in SCO and notice patron's own branch printed in the slip 3) Apply patch 4) Print a slip in SCO and notice the branch is now the staff id's branch used to sign in to SCO patron view.
Lari, IS the idea here to print the branch specific slip of the AutoSelfCheck user?
(In reply to Lucas Gass from comment #3) > Lari, > > IS the idea here to print the branch specific slip of the AutoSelfCheck user? The SCO uses the default issue slip in my case. Of course same applies for branch specific slips too. Without the patch the code is sending the logged in patron's branch to the function that generates the slip.
(In reply to Lucas Gass from comment #3) > Lari, > > IS the idea here to print the branch specific slip of the AutoSelfCheck user? I think if set, yes, but it should use the home library of the logged in staff user actually. That could match AutoSelfCheck.
Hi Lari, thx for your patch! I see that your commit message is missing the description and test plan see in comment#1. Please note that when using git bz you can type things into the message when doing git bz attach, but it won't update the commit message. Use git commit --amend before uploading instead. Now to test...
Created attachment 140267 [details] [review] Bug 31496: Fix branch in printslip.pl to logged in staff user's library When you print a receipt slip in SCO, the library/branch you are at in should be fetched from the logged in staff member's data (staff login done before entering SCO view) instead of the patron's own who has signed in to the SCO. Printing a slip shows patron's own home branch in the slip as the branch they're in. This causes confusion with patrons who want to print receipts/slips. Test plan: 1) Make sure the staff user's library (used to login into SCO patron view) is not the same as the patron's who is logging into SCO 2) Print a slip in SCO and notice patron's home library printed on the slip 3) Apply patch 4) Print a slip in SCO and notice the library is now the staff user's library used to sign in to SCO patron view. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Change looks good however the author information is incomplete: lmstrand <lmstrand@gmail.com>. This will come handy when trying to figure out copyright holders of Koha if there is ever any issues. Could you re-attach the patch with your real name?
Created attachment 140961 [details] [review] Bug 31496: Fix branch in printslip.pl to logged in staff user's library When you print a receipt slip in SCO, the library/branch you are at in should be fetched from the logged in staff member's data (staff login done before entering SCO view) instead of the patron's own who has signed in to the SCO. Printing a slip shows patron's own home branch in the slip as the branch they're in. This causes confusion with patrons who want to print receipts/slips. Test plan: 1) Make sure the staff user's library (used to login into SCO patron view) is not the same as the patron's who is logging into SCO 2) Print a slip in SCO and notice patron's home library printed on the slip 3) Apply patch 4) Print a slip in SCO and notice the library is now the staff user's library used to sign in to SCO patron view. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!