If you visit in staff interface club enrollment page for a non-existent club you get a somewhat broken page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=1010101001000 We should provide a clear error message that the club the user tried to view doesn't exists.
Created attachment 140178 [details] [review] Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=1010101001000 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given
Created attachment 140179 [details] [review] Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=1010101001000 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given
Created attachment 140326 [details] [review] Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=1010101001000 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given Signed-off-by: David Nind <david@davidnind.com>
Created attachment 140475 [details] [review] Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=1010101001000 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix, Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.07 release
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.