When AnonSuggestions are allowed and you click on 'purchase suggestions' in the navigation bar while not logged in, the breadcrumb will look like this: Home > > Your purchase suggestions I think we might be missing some construct to deal with the 'not logged in' to remove one of those > in this case.
Created attachment 140856 [details] [review] Bug 31527: Breadcrumbs for anonymous suggestions are not correct This patch updates the OPAC suggestions template in order to omit the patron name breadcrumb if there is not a logged-in user. To test, apply the patch and view the OPAC suggestions page with the AnonSuggestions preference both enabled and disabled. - If you are logged in, the page breadcrumbs will be: Home -> [Your name] -> Purchase suggestions. - If you are not logged in it should be: Home -> Purchase suggestions
Created attachment 140876 [details] [review] Bug 31527: Breadcrumbs for anonymous suggestions are not correct This patch updates the OPAC suggestions template in order to omit the patron name breadcrumb if there is not a logged-in user. To test, apply the patch and view the OPAC suggestions page with the AnonSuggestions preference both enabled and disabled. - If you are logged in, the page breadcrumbs will be: Home -> [Your name] -> Purchase suggestions. - If you are not logged in it should be: Home -> Purchase suggestions Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using koha-testing-docker): 1. Enable AnonSuggestions system preference 2. Set AnonymousPatron system preference to a valid patron number, such as 42
Trivial fix, the template changes look good, QA scripts are happy.
Created attachment 140914 [details] [review] Attachment to Bug 31527 - Breadcrumbs for anonymous suggestions are not correct Bug 31527: Breadcrumbs for anonymous suggestions are not correct This patch updates the OPAC suggestions template in order to omit the patron name breadcrumb if there is not a logged-in user. To test, apply the patch and view the OPAC suggestions page with the AnonSuggestions preference both enabled and disabled. - If you are logged in, the page breadcrumbs will be: Home -> [Your name] -> Purchase suggestions. - If you are not logged in it should be: Home -> Purchase suggestions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.07 release
applied to 21.11 for 21.11.14
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.