Bug 31585 - "ACQUISITION ORDER" action missing from log viewer search form
Summary: "ACQUISITION ORDER" action missing from log viewer search form
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-20 11:58 UTC by Katrin Fischer
Modified: 2023-12-28 20:46 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07
Circulation function:


Attachments
Bug 31585: Fix 'acquisition order' and 'acquisition claim' (2.73 KB, patch)
2023-05-18 10:27 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 31585: Fix 'acquisition order' and 'acquisition claim' (2.75 KB, patch)
2023-05-18 11:42 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface (1.15 KB, patch)
2023-05-18 12:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31585: Fix 'acquisition order' and 'acquisition claim' (2.82 KB, patch)
2023-05-18 12:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface (1.15 KB, patch)
2023-05-18 12:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31585: Fix 'acquisition order' and 'acquisition claim' (2.92 KB, patch)
2023-05-19 09:12 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface (1.24 KB, patch)
2023-05-19 09:12 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-09-20 11:58:44 UTC
When an ACQORDER email is sent, this is logged, but we cannot search for it nicely from the log viewer form. (or I missed it!)
Comment 1 Katrin Fischer 2022-09-20 14:16:42 UTC
Hm, I am a little baffled here, because it looks like the entries are in the template file, but don't show up on the form:

[%        CASE 'SERIAL CLAIM' %]<span>Serial claim</span>
[%        CASE 'ACQUISITION CLAIM' %]<span>Acquisition claim</span>
[%        CASE 'ACQUISITION ORDER' %]<span>Acquisition order</span>
Comment 2 Pedro Amorim 2023-05-18 10:27:58 UTC
Created attachment 151385 [details] [review]
Bug 31585: Fix 'acquisition order' and 'acquisition claim'

Added 'ACQUISITION CLAIM' and 'ACQUISITION ORDER' to the log viewer form.
Please test this well (making sure there are log entries of these types and they show properly upon searching for them)
Comment 3 Pedro Amorim 2023-05-18 11:42:08 UTC
Created attachment 151396 [details] [review]
Bug 31585: Fix 'acquisition order' and 'acquisition claim'

Added 'ACQUISITION CLAIM' and 'ACQUISITION ORDER' to the log viewer form.
Please test this well (making sure there are log entries of these types and they show properly upon searching for them)
Comment 4 Katrin Fischer 2023-05-18 12:10:07 UTC
Created attachment 151397 [details] [review]
Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface

Just a small fix renaming one of the options to comply
with terminology guidelines.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-05-18 12:10:23 UTC
Created attachment 151398 [details] [review]
Bug 31585: Fix 'acquisition order' and 'acquisition claim'

Added 'ACQUISITION CLAIM' and 'ACQUISITION ORDER' to the log viewer form.
Please test this well (making sure there are log entries of these types and they show properly upon searching for them)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-05-18 12:10:25 UTC
Created attachment 151399 [details] [review]
Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface

Just a small fix renaming one of the options to comply
with terminology guidelines.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Marcel de Rooy 2023-05-19 09:12:33 UTC
Created attachment 151461 [details] [review]
Bug 31585: Fix 'acquisition order' and 'acquisition claim'

Added 'ACQUISITION CLAIM' and 'ACQUISITION ORDER' to the log viewer form.
Please test this well (making sure there are log entries of these types and they show properly upon searching for them)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2023-05-19 09:12:35 UTC
Created attachment 151462 [details] [review]
Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface

Just a small fix renaming one of the options to comply
with terminology guidelines.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Katrin Fischer 2023-05-19 13:30:23 UTC
Just drop my follow-up to make this string-change-free. I'll post it on a separate bug.
Comment 10 Tomás Cohen Arazi (tcohen) 2023-05-19 18:06:23 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 11 Matt Blenkinsop 2023-06-08 17:09:33 UTC
Nice work everyone!

Pushed to stable for 22.11.x