At the moment reporting on sent out order emails is complicated by the fact that the ordernumber is not available in the log entries. The object is left empty and should be set to the basketno.
Created attachment 140784 [details] [review] Bug 31586: Log basket number as object for action ACQUISITION ORDER Until now we logged undef as object in action_logs when an email order was sent. With this patch the basket number is logged instead, which will allow for reporting and also allows us to display a link to the basket, if permissions permit (order manage), in the log viewer. To test: - Make sure the ClaimsLog system preference is set to Log - Create a vendor or make sure an existing vendor has an email set - Make sure to add an SMTP server and link it to your library - Create a basket in acqisitions and add an order line - Click "E-mail order" to send the email - Go to the log viewer, limit to module Acquisitions - Verify that the entry show with a link to the basket in the Object column If the user doesn't have order_manage permission, the basket number will still show, but isn't linked
Created attachment 140785 [details] [review] Bug 31586: Log basket number as object for action ACQUISITION ORDER Until now we logged undef as object in action_logs when an email order was sent. With this patch the basket number is logged instead, which will allow for reporting and also allows us to display a link to the basket, if permissions permit (order manage), in the log viewer. To test: - Make sure the ClaimsLog system preference is set to Log - Create a vendor or make sure an existing vendor has an email set - Make sure to add an SMTP server and link it to your library - Create a basket in acqisitions and add an order line - Click "E-mail order" to send the email - Go to the log viewer, limit to module Acquisitions - Verify that the entry show with a link to the basket in the Object column If the user doesn't have order_manage permission, the basket number will still show, but isn't linked
Created attachment 140825 [details] [review] Bug 31586: Log basket number as object for action ACQUISITION ORDER Until now we logged undef as object in action_logs when an email order was sent. With this patch the basket number is logged instead, which will allow for reporting and also allows us to display a link to the basket, if permissions permit (order manage), in the log viewer. To test: - Make sure the ClaimsLog system preference is set to Log - Create a vendor or make sure an existing vendor has an email set - Make sure to add an SMTP server and link it to your library - Create a basket in acqisitions and add an order line - Click "E-mail order" to send the email - Go to the log viewer, limit to module Acquisitions - Verify that the entry show with a link to the basket in the Object column If the user doesn't have order_manage permission, the basket number will still show, but isn't linked Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 141258 [details] [review] Bug 31586: Log basket number as object for action ACQUISITION ORDER Until now we logged undef as object in action_logs when an email order was sent. With this patch the basket number is logged instead, which will allow for reporting and also allows us to display a link to the basket, if permissions permit (order manage), in the log viewer. To test: - Make sure the ClaimsLog system preference is set to Log - Create a vendor or make sure an existing vendor has an email set - Make sure to add an SMTP server and link it to your library - Create a basket in acqisitions and add an order line - Click "E-mail order" to send the email - Go to the log viewer, limit to module Acquisitions - Verify that the entry show with a link to the basket in the Object column If the user doesn't have order_manage permission, the basket number will still show, but isn't linked Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!