Bug 31593 - Remove Test::DBIx::Class from Context.t
Summary: Remove Test::DBIx::Class from Context.t
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-21 13:54 UTC by Marcel de Rooy
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15
Circulation function:

Attachments
Bug 31593: Remove Test::DBIx::Class from Context.t (1.18 KB, patch)
2022-09-21 13:56 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 31593: Remove Test::DBIx::Class from Context.t (1.20 KB, patch)
2022-10-02 09:25 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-09-21 13:54:44 UTC 
We do not need the module here. Also fixing a test description.
Comment 1 Marcel de Rooy 2022-09-21 13:56:39 UTC 
Created attachment 140818 [details] [review]
Bug 31593: Remove Test::DBIx::Class from Context.t

No need to keep it.
Fixing a test description too.

Test plan:
Run t/db_dependent/Context.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2022-09-21 13:56:59 UTC 
Trivial: SO
Comment 3 Katrin Fischer 2022-10-02 09:25:37 UTC 
Created attachment 141204 [details] [review]
Bug 31593: Remove Test::DBIx::Class from Context.t

No need to keep it.
Fixing a test description too.

Test plan:
Run t/db_dependent/Context.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-10-03 15:42:25 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass (lukeg) 2022-12-05 16:00:52 UTC 
Backported to 22.05.x for upcoming 22.05.08 release
Comment 6 Arthur Suzuki 2022-12-14 09:53:08 UTC 
applied to 21.11 for 21.11.15
Comment 7 Wainui Witika-Park 2022-12-20 01:40:18 UTC 
Backported to 21.05.x for 21.05.22
Comment 8 Wainui Witika-Park 2022-12-23 00:21:52 UTC 
Not releasing in 21.05.22
Comment 9 Wainui Witika-Park 2023-03-15 00:44:11 UTC 
(In reply to wainuiwitikapark from comment #8)
> Not releasing in 21.05.22

Reverted from 21.05 branch