When a report has more than 20 results, but not a multiple of twenty the final page can have 5 results say, but koha still says: 25 results (20 shown) We should count the number of results for display of shown
Created attachment 140821 [details] [review] Bug 31594: Use ount of results for displaying number shown To test: 1 - Create a report with a number of results that is not a multiple of 20 SELECT barcode FROM items 2 - Run the report 3 - Go to the final page 4 - Note report says 20 shown, but there are less 5 - Apply patch 6 - Reload and confirm correct number of shown is shown :-)
Created attachment 140827 [details] [review] Bug 31594: Use ount of results for displaying number shown To test: 1 - Create a report with a number of results that is not a multiple of 20 SELECT barcode FROM items 2 - Run the report 3 - Go to the final page 4 - Note report says 20 shown, but there are less 5 - Apply patch 6 - Reload and confirm correct number of shown is shown :-) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 141203 [details] [review] Bug 31594: Use ount of results for displaying number shown To test: 1 - Create a report with a number of results that is not a multiple of 20 SELECT barcode FROM items 2 - Run the report 3 - Go to the final page 4 - Note report says 20 shown, but there are less 5 - Apply patch 6 - Reload and confirm correct number of shown is shown :-) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Small logical fix, nice enhancement - love :)
Created attachment 141262 [details] [review] Bug 31594: Use count of results for displaying number shown To test: 1 - Create a report with a number of results that is not a multiple of 20 SELECT barcode FROM items 2 - Run the report 3 - Go to the final page 4 - Note report says 20 shown, but there are less 5 - Apply patch 6 - Reload and confirm correct number of shown is shown :-) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.08 release
applied to 21.11 for 21.11.15