1572 =head2 RecordsFromMARCXMLFile 1573 1574 my ($errors, $records) = C4::ImportBatch::RecordsFromMARCXMLFile($input_file, $encoding); 1575 1576 Creates MARC::Record-objects out of the given MARCXML-file. 1577 1578 @PARAM1, String, absolute path to the ISO2709 file. The last line should say MARCXML, not ISO2709.
Created attachment 152306 [details] [review] Bug 31618: Fix typo in POD for C4::ImportBatch::RecordsFromMARCXMLFile To test: 1) Apply the patch 2) Visit C4::ImportBatch::RecordsFromMARCXMLFile 3) See that in the POD (mine was somewhere around line 1592) the line starting with '@PARAM1' now says '@PARAM1, String, absolute path to the MARCXML file.' 4) Sign off :)
Created attachment 152323 [details] [review] Bug 31618: Fix typo in POD for C4::ImportBatch::RecordsFromMARCXMLFile To test: 1) Apply the patch 2) Visit C4::ImportBatch::RecordsFromMARCXMLFile 3) See that in the POD (mine was somewhere around line 1592) the line starting with '@PARAM1' now says '@PARAM1, String, absolute path to the MARCXML file.' 4) Sign off :) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
The git diff was a bit confusing here, as it looks like this POD was changed: =head2 RecordsFromISO2709File my ($errors, $records) = C4::ImportBatch::RecordsFromISO2709File($input_file, $record_type, $encoding); Reads ISO2709 binary porridge from the given file and creates MARC::Record-objects out of it. @PARAM1, String, absolute path to the ISO2709 file. @PARAM2, String, see stage_file.pl @PARAM3, String, should be utf8 Returns two array refs. =cut But it's actually this one: =head2 RecordsFromMARCXMLFile my ($errors, $records) = C4::ImportBatch::RecordsFromMARCXMLFile($input_file, $encoding); Creates MARC::Record-objects out of the given MARCXML-file. @PARAM1, String, absolute path to the MARCXML file. @PARAM2, String, should be utf8 Returns two array refs. =cut So we are good! Welcome Sam to the Koha devs!
Created attachment 152589 [details] [review] Bug 31618: Fix typo in POD for C4::ImportBatch::RecordsFromMARCXMLFile To test: 1) Apply the patch 2) Visit C4::ImportBatch::RecordsFromMARCXMLFile 3) See that in the POD (mine was somewhere around line 1592) the line starting with '@PARAM1' now says '@PARAM1, String, absolute path to the MARCXML file.' 4) Sign off :) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
(In reply to Katrin Fischer from comment #3) > So we are good! Welcome Sam to the Koha devs! Thanks, Katrin!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to 22.11.x for next release