When looking at the MARC preview for an authority search result, the preview modal appears empty since the contents are taken from a page with tabs that are hidden by default. Removing the "tab-content" class from the div solves this problem.
Created attachment 141109 [details] [review] Bug 31660: MARC preview for authority search results has hidden contents This patch makes the contents of the MARC preview for authority search results visible. To test: 1) Go to the Authorities page in the staff interface 2) Click Submit to do a search 3) Click on Actions to the right of an authority 4) Select MARC preview 5) Observe that the modal appears empty 6) Apply patch 7) Hold down the shift key when you reload the page, clear the cache, or use another web browser 8) Do another authority search and look at a MARC preview 9) Observe that the MARC preview contains the MARC record
Created attachment 141127 [details] [review] Bug 31660: MARC preview for authority search results has hidden contents This patch makes the contents of the MARC preview for authority search results visible. To test: 1) Go to the Authorities page in the staff interface 2) Click Submit to do a search 3) Click on Actions to the right of an authority 4) Select MARC preview 5) Observe that the modal appears empty 6) Apply patch 7) Hold down the shift key when you reload the page, clear the cache, or use another web browser 8) Do another authority search and look at a MARC preview 9) Observe that the MARC preview contains the MARC record Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Hi Kevin, please add yourself as Assignee whenever you start working on a bug/plan to provide a patch. Thx!
Created attachment 141209 [details] [review] Bug 31660: MARC preview for authority search results has hidden contents This patch makes the contents of the MARC preview for authority search results visible. To test: 1) Go to the Authorities page in the staff interface 2) Click Submit to do a search 3) Click on Actions to the right of an authority 4) Select MARC preview 5) Observe that the modal appears empty 6) Apply patch 7) Hold down the shift key when you reload the page, clear the cache, or use another web browser 8) Do another authority search and look at a MARC preview 9) Observe that the MARC preview contains the MARC record Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice catch!
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.08
MARC Preview action not available in 21.11. won't backport