Bug 31660 - MARC preview for authority search results comes up empty
Summary: MARC preview for authority search results comes up empty
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kevin Carnes
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-30 07:22 UTC by Kevin Carnes
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15


Attachments
Bug 31660: MARC preview for authority search results has hidden contents (1.78 KB, patch)
2022-09-30 07:35 UTC, Kevin Carnes
Details | Diff | Splinter Review
Bug 31660: MARC preview for authority search results has hidden contents (1.83 KB, patch)
2022-09-30 12:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31660: MARC preview for authority search results has hidden contents (1.89 KB, patch)
2022-10-02 11:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Carnes 2022-09-30 07:22:17 UTC
When looking at the MARC preview for an authority search result, the preview modal appears empty since the contents are taken from a page with tabs that are hidden by default.

Removing the "tab-content" class from the div solves this problem.
Comment 1 Kevin Carnes 2022-09-30 07:35:27 UTC
Created attachment 141109 [details] [review]
Bug 31660: MARC preview for authority search results has hidden contents

This patch makes the contents of the MARC preview for authority search results
visible.

To test:
1)  Go to the Authorities page in the staff interface
2)  Click Submit to do a search
3)  Click on Actions to the right of an authority
4)  Select MARC preview
5)  Observe that the modal appears empty
6)  Apply patch
7)  Hold down the shift key when you reload the page, clear the cache, or use
another web browser
8)  Do another authority search and look at a MARC preview
9)  Observe that the MARC preview contains the MARC record
Comment 2 Owen Leonard 2022-09-30 12:23:09 UTC
Created attachment 141127 [details] [review]
Bug 31660: MARC preview for authority search results has hidden contents

This patch makes the contents of the MARC preview for authority search
results visible.

To test:
1)  Go to the Authorities page in the staff interface
2)  Click Submit to do a search
3)  Click on Actions to the right of an authority
4)  Select MARC preview
5)  Observe that the modal appears empty
6)  Apply patch
7)  Hold down the shift key when you reload the page, clear the cache,
    or use another web browser
8)  Do another authority search and look at a MARC preview
9)  Observe that the MARC preview contains the MARC record

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2022-10-01 07:53:45 UTC
Hi Kevin, please add yourself as Assignee whenever you start working on a bug/plan to provide a patch. Thx!
Comment 4 Katrin Fischer 2022-10-02 11:00:12 UTC
Created attachment 141209 [details] [review]
Bug 31660: MARC preview for authority search results has hidden contents

This patch makes the contents of the MARC preview for authority search
results visible.

To test:
1)  Go to the Authorities page in the staff interface
2)  Click Submit to do a search
3)  Click on Actions to the right of an authority
4)  Select MARC preview
5)  Observe that the modal appears empty
6)  Apply patch
7)  Hold down the shift key when you reload the page, clear the cache,
    or use another web browser
8)  Do another authority search and look at a MARC preview
9)  Observe that the MARC preview contains the MARC record

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-10-02 11:00:30 UTC
Nice catch!
Comment 6 Tomás Cohen Arazi 2022-10-03 18:15:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-12-05 16:56:06 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 8 Arthur Suzuki 2022-12-14 12:11:20 UTC
MARC Preview action not available in 21.11. won't backport