'tip' and 'hint' are classes for a CSS with grey color. Looks like 'hint' is way more used that 'tip' (mainly used for header search boxes). I think we should replace 'tip' with 'hint' to have only one class for this usage. And maybe add a coding guide line.
> git grep -e 'class="hint[ "]' -- koha-tmpl/ | wc -l 343 > git grep -e 'class="tip[ "]' -- koha-tmpl/ | wc -l 42 They may be few places where this class is not the first. But hint is clearly the boss ;)
Created attachment 153888 [details] [review] Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate.
There is another CSS rule in staff-global.scss : label { ... &.tip { display: block; margin: .5em 0; }
Created attachment 154233 [details] [review] Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate.
Created attachment 154236 [details] [review] Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Thanks a lot Owen for the additional work ;)
Created attachment 154261 [details] [review] Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.03
Nice work everyone! Pushed to 22.11.x for next release