Bug 31685 - Article request count in table caption of opac-user missing
Summary: Article request count in table caption of opac-user missing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-05 13:44 UTC by Marcel de Rooy
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15


Attachments
Bug 31685: Replace current_article_requests_count in opac-user (1.51 KB, patch)
2022-10-05 13:51 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-10-05 13:44:49 UTC
It mentions Article requests ( total)
The total does appear on the tab itself.

Reason: The template still refers to current_article_requests_count which has been replaced.
Trivial fix forthcoming.
Comment 1 Marcel de Rooy 2022-10-05 13:51:03 UTC
Created attachment 141381 [details] [review]
Bug 31685: Replace current_article_requests_count in opac-user

Fixing the "( total)" in the caption of the table.

The tt var should be replaced now by current_article_requests.size.
Note that current_article_requests is an array now (from as_list).
We cannot use .count since it is no Koha object.

Test plan:
Submit a few article requests.
Check OPAC account page, and verify that both totals are fine now.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2022-10-05 13:52:03 UTC
One liner for Tomas.
Comment 3 Tomás Cohen Arazi 2022-10-05 19:35:27 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 4 Lucas Gass 2022-12-05 17:01:17 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 5 Arthur Suzuki 2022-12-14 12:23:39 UTC
applied to 21.11 for 21.11.15
Comment 6 wainuiwitikapark 2022-12-20 01:56:30 UTC
Backported to 21.05.x for 21.05.22
Comment 7 wainuiwitikapark 2022-12-23 00:26:27 UTC
Not released in 21.05.22
Comment 8 wainuiwitikapark 2023-03-15 00:38:21 UTC
(In reply to wainuiwitikapark from comment #7)
> Not released in 21.05.22

Reverted from 21.05 branch