Created attachment 141524 [details] [review] Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated
Created attachment 141525 [details] [review] Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated
Created attachment 141940 [details] [review] Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD) ------------------------- To install the German language: cd misc/translator ./translate install de-DE To get the web installer running, I used this process: 1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on 5. koha_kohadev.* to koha_kohadev; 6. Restart everything (may not be required, but just to be safe): flush_memcached + restart_all 7. Access the web installer: go to 127.0.0.1:8081 8. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 9. Continue through the installation process Note: [1] Database password is password (from KTD .env file) German translations for different languages: I don't speak German, but I think Katrin knows these! 8-)
Thank you, David! The grant permissions might not be needed if you drop + create the database without restarting anything in between, at least I ususally do it that way :)
Created attachment 142302 [details] [review] Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Looks good to me. Just found this thing: INSERT INTO language_descriptions(subtag, type, lang, description) -VALUES ( 'la', 'language', 'de', 'Latein'); +VALUES ( 'la', 'language', 'de', 'Lateinisch'); It is in the installer file. But not in the dbrev. So could be considered as an inconsistency. Feel free to add a QA follow-up :)
Pushed to master for 22.11. Nice work everyone, thanks!