We now have the system preference EDIFACT to turn/on off the EDI functionality. If a vendor has no EDI information linked to it, we currently show this note on the basket group page: No EDIFACT configuration for My Vendor The visibilitey/display of this note should depend on the preference setting.
Created attachment 148972 [details] [review] Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)"
Created attachment 148976 [details] [review] Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)" Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 149354 [details] [review] Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)" Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Doesn't apply clean to 22.05.x, no backport.