Bug 31738 - Unstranslatable string in checkouts.js for recalls
Summary: Unstranslatable string in checkouts.js for recalls
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-11 16:29 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08


Attachments
Bug 31738: Fix untanslatable string for recalls (1.76 KB, patch)
2022-10-15 22:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31738: Fix untanslatable string for recalls (1.81 KB, patch)
2022-10-16 19:19 UTC, David Nind
Details | Diff | Splinter Review
Bug 31738: Fix untranslatable string for recalls (1.91 KB, patch)
2022-10-21 08:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-10-11 16:29:24 UTC
When an item has been recalled, there is a red message in the current borrower's checkout list that says "This item has been recalled and the due date updated."

I can't find this string anywhere in the translation files.

The original string is in koha-tmpl/intranet-tmpl/prog/js/checkouts.js

To get this message:
1. Turn on recalls
   1.1. In Administration > Global system preferences, enable UseRecalls
   1.2. Add recalls permissions in your circulation rules
2. In the OPAC, log in as a patron
3. Find a record with checked out items and place a recall
4. In the intranet, go to the patron file of the patron who currently has that item checked out
--> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title
Comment 1 Katrin Fischer 2022-10-15 22:21:14 UTC
Created attachment 141935 [details] [review]
Bug 31738: Fix untanslatable string for recalls

To test translation:
1. Apply patch and update your po files using:
   https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
2. Verify the string appears in po files now and translate it
3. Install the language

To test functionality:
1. Turn on recalls
   1.1. In Administration > Global system preferences, enable UseRecalls
   1.2. Add recalls permissions in your circulation rules
2. In the OPAC, log in as a patron
3. Find a record with checked out items and place a recall
4. In the intranet, go to the patron file of the patron who currently has that item checked out
--> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title
Comment 2 David Nind 2022-10-16 19:19:44 UTC
Created attachment 141946 [details] [review]
Bug 31738: Fix untanslatable string for recalls

To test translation:
1. Apply patch and update your po files using:
   https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
2. Verify the string appears in po files now and translate it
3. Install the language

To test functionality:
1. Turn on recalls
   1.1. In Administration > Global system preferences, enable UseRecalls
   1.2. Add recalls permissions in your circulation rules
2. In the OPAC, log in as a patron
3. Find a record with checked out items and place a recall
4. In the intranet, go to the patron file of the patron who currently has that item checked out
--> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2022-10-21 08:28:14 UTC
Created attachment 142303 [details] [review]
Bug 31738: Fix untranslatable string for recalls

To test translation:
1. Apply patch and update your po files using:
   https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
2. Verify the string appears in po files now and translate it
3. Install the language

To test functionality:
1. Turn on recalls
   1.1. In Administration > Global system preferences, enable UseRecalls
   1.2. Add recalls permissions in your circulation rules
2. In the OPAC, log in as a patron
3. Find a record with checked out items and place a recall
4. In the intranet, go to the patron file of the patron who currently has that item checked out
--> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2022-10-21 12:58:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-12-05 20:58:54 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 6 Arthur Suzuki 2022-12-16 13:33:02 UTC
recalls not available in 21.11. won't apply.