Bug 3174 - Fill the borrowernumber field, and show author and creation date
Summary: Fill the borrowernumber field, and show author and creation date
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: rel_3_2
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nahuel Angelinetti
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-30 09:34 UTC by Nahuel Angelinetti
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
bugfix (3.91 KB, patch)
2009-04-30 09:37 UTC, Chris Cormack
Details | Diff | Splinter Review
follow up (2.13 KB, patch)
2009-05-04 15:17 UTC, Chris Cormack
Details | Diff | Splinter Review
no patron name - only number (43.67 KB, image/png)
2009-05-08 18:55 UTC, Chris Cormack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:07:19 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2009-04-30 09:34:50 ----

The field borrowernumber in reports table should be filled in, and then in the "Use Saved" page, the creator and the creation date should be shown.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-04-30 09:37:18 ----

Created an attachment
bugfix





---- Additional Comments From gmcharlt@gmail.com 2009-05-01 21:31:15 ----

Patch pushed to HEAD.  However, this bug should remain open: displaying the *borrowernumber* of the staff user who created a report is not friendly to the user - the name should be displayed, at least.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-05-04 15:17:19 ----

Created an attachment
follow up





---- Additional Comments From gmcharlt@gmail.com 2009-05-08 15:20:14 ----

Pushed followup patch.  Please test and close.



---- Additional Comments From nengard@gmail.com 2009-05-08 18:32:00 ----

I have applied all patches and yet I do not see information about the report creator on my 'use saved' page.



---- Additional Comments From nengard@gmail.com 2009-05-08 18:55:10 ----

Created an attachment
no patron name - only number

I see the member number in parens on my screen - not a name ... 



---- Additional Comments From gmcharlt@gmail.com 2009-05-08 18:57:05 ----

If the number is 0, that's the main superlibrarian for the database, which doesn't have a real borrower record, and hence no name.  It's also possible that it belongs to a staff user that you subsequently deleted.  If neither applies, then there may be a bug.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-05-11 09:57:00 ----

If the userid is "0", only "(0)" will be shown, I think if the user no longer exist, if the borrowernumber is null, the cell will be empty.
And if the borrowernumber doesn't correspond to a real borrower, the cell will appear like if the userid is "0". 




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:07 UTC  ---

This bug was previously known as _bug_ 3174 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3174
Imported an attachment (id=1144)
Imported an attachment (id=1145)
Imported an attachment (id=1146)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1144 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1145 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1146 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Owen Leonard 2011-05-20 18:52:03 UTC
Can this be closed?
Comment 2 Owen Leonard 2011-08-22 16:53:33 UTC
Saved reports page shows both librarian name and librarian borrowernumber for each saved report. Looks fixed to me.