Bug 31751 - Breadcrumb style
Summary: Breadcrumb style
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-12 21:45 UTC by David Nind
Modified: 2023-06-08 22:28 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Breadcrumbs reverted to the old style (115.63 KB, image/png)
2022-10-20 11:41 UTC, Owen Leonard
Details
Breadcrumbs using a caret icon (98.57 KB, image/png)
2022-10-20 11:42 UTC, Owen Leonard
Details
Bug 31751: Breadcrumb style (1.67 KB, patch)
2022-11-15 19:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31751: Breadcrumb style (1.72 KB, patch)
2022-11-15 19:58 UTC, David Nind
Details | Diff | Splinter Review
Bug 31751: Breadcrumb style (1.77 KB, patch)
2022-11-16 12:43 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2022-10-12 21:45:03 UTC
Personally, I prefer breadcrumbs to use the > rather than the /.

In addition, I think they should be normal text rather than italics/emphasis.

I think the size for this are OK - visible, but not intrusive.

Some research on breadcrumbs from the Nielsen Norman Group:

Breadcrumbs: 11 Design Guidelines for Desktop and Mobile. 23 December 2018.
https://www.nngroup.com/articles/breadcrumbs/
Comment 1 Fridolin Somers 2022-10-20 01:24:55 UTC
> I prefer breadcrumbs to use the > rather than the /.
I say we should use an icon like caret :
https://fontawesome.com/v4/icon/caret-right

> normal text rather than italics/emphasis
+1
Comment 2 Owen Leonard 2022-10-20 11:41:36 UTC
Created attachment 142240 [details]
Breadcrumbs reverted to the old style

Screenshot showing breadcrumbs reverted to the old style
Comment 3 Owen Leonard 2022-10-20 11:42:09 UTC
Created attachment 142241 [details]
Breadcrumbs using a caret icon

Screenshot showing breadcrumbs using a caret icon
Comment 4 Martin Renvoize 2022-10-21 10:20:41 UTC
I think I just about prefer the old style rather than the new caret icon... but it's a close call for me.. I like them both better than the current `/`
Comment 5 Martin Renvoize 2022-11-07 17:24:22 UTC
Anyone else got an opinion here?
Comment 6 David Nind 2022-11-07 17:56:39 UTC
The older style for me (>)(ideally without the italics).
Comment 7 Tomás Cohen Arazi 2022-11-07 17:58:47 UTC
Older style (>), normal text.
Comment 8 Tomás Cohen Arazi 2022-11-15 17:20:15 UTC
Any news?
Comment 9 Owen Leonard 2022-11-15 19:24:46 UTC
Created attachment 143926 [details] [review]
Bug 31751: Breadcrumb style

This patch updates the breadcrumb style to use the old caret icon
instead of a slash.

I've left the italic because I think it works well to set the text off
from the normal text above, in the search bar, and below in the main
body of the page.

To test, apply the patch and rebuild the staff interface CSS. Look at
various pages in the staff interface and check the style of the
breadcrumbs menu.
Comment 10 David Nind 2022-11-15 19:58:07 UTC
Created attachment 143928 [details] [review]
Bug 31751: Breadcrumb style

This patch updates the breadcrumb style to use the old caret icon
instead of a slash.

I've left the italic because I think it works well to set the text off
from the normal text above, in the search bar, and below in the main
body of the page.

To test, apply the patch and rebuild the staff interface CSS. Look at
various pages in the staff interface and check the style of the
breadcrumbs menu.

Signed-off-by: David Nind <david@davidnind.com>
Comment 11 Tomás Cohen Arazi 2022-11-16 12:43:34 UTC
Created attachment 143950 [details] [review]
Bug 31751: Breadcrumb style

This patch updates the breadcrumb style to use the old caret icon
instead of a slash.

I've left the italic because I think it works well to set the text off
from the normal text above, in the search bar, and below in the main
body of the page.

To test, apply the patch and rebuild the staff interface CSS. Look at
various pages in the staff interface and check the style of the
breadcrumbs menu.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 12 Tomás Cohen Arazi 2022-11-16 12:47:05 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!