Bug 31763 - Add 'page-section' to patron lists page
Summary: Add 'page-section' to patron lists page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-13 12:10 UTC by Martin Renvoize
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31763: Add 'page-section' to patron lists page (16.39 KB, patch)
2022-10-13 18:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31763: Add 'page-section' to patron lists page (16.45 KB, patch)
2022-10-13 19:47 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31763: Add 'page-section' to patron lists page (16.50 KB, patch)
2022-10-13 20:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 31763: Add 'page-section' to patron lists page (16.56 KB, patch)
2022-10-14 08:25 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-13 12:10:53 UTC
We need the page-section div adding to patron lists page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Owen Leonard 2022-10-13 18:03:52 UTC
Created attachment 141835 [details] [review]
Bug 31763: Add 'page-section' to patron lists page

This patch updates patron lists templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Unrelated change: I wrapped some form controls in a <fieldset> to make
it consistent with other pages and to work better with the updated
markup.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron lists.

- If necessary, create one or more patron lists so that the table
  appears. Confirm that the content area looks correct.
- Click Actions -> Add patrons to confirm that the screen
  looks correct.
Comment 2 Lucas Gass 2022-10-13 19:47:27 UTC
Created attachment 141840 [details] [review]
Bug 31763: Add 'page-section' to patron lists page

This patch updates patron lists templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Unrelated change: I wrapped some form controls in a <fieldset> to make
it consistent with other pages and to work better with the updated
markup.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron lists.

- If necessary, create one or more patron lists so that the table
  appears. Confirm that the content area looks correct.
- Click Actions -> Add patrons to confirm that the screen
  looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 David Nind 2022-10-13 20:51:26 UTC
Created attachment 141845 [details] [review]
Bug 31763: Add 'page-section' to patron lists page

This patch updates patron lists templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Unrelated change: I wrapped some form controls in a <fieldset> to make
it consistent with other pages and to work better with the updated
markup.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron lists.

- If necessary, create one or more patron lists so that the table
  appears. Confirm that the content area looks correct.
- Click Actions -> Add patrons to confirm that the screen
  looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-10-13 21:08:18 UTC
I hadn't refreshed the page - I now see it was already signed off!

I notice that the auto complete for patron search when adding patrons to a list is not working (it wasn't working before the patch was applied).

Should this be a separate bug?
Comment 5 Lucas Gass 2022-10-13 21:16:36 UTC
(In reply to David Nind from comment #4)
> I hadn't refreshed the page - I now see it was already signed off!
> 
> I notice that the auto complete for patron search when adding patrons to a
> list is not working (it wasn't working before the patch was applied).
> 
> Should this be a separate bug?

Never hurts to have 2 sign-offs!

I see there is a JS error on that page and that is likely why the auto complete function is broken:

Uncaught TypeError: $(...).autocomplete(...).data(...) is undefined

Let's file a separate bug for that.
Comment 6 David Nind 2022-10-13 21:52:55 UTC
(In reply to Lucas Gass from comment #5)
> Let's file a separate bug for that.

Bug 31782 created for this.
Comment 7 Martin Renvoize 2022-10-14 08:25:05 UTC
Created attachment 141865 [details] [review]
Bug 31763: Add 'page-section' to patron lists page

This patch updates patron lists templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Unrelated change: I wrapped some form controls in a <fieldset> to make
it consistent with other pages and to work better with the updated
markup.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron lists.

- If necessary, create one or more patron lists so that the table
  appears. Confirm that the content area looks correct.
- Click Actions -> Add patrons to confirm that the screen
  looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2022-10-14 08:26:03 UTC
Looks good, thanks for the quick work.

Passing QA..

Thanks for opening another bug regarding autocomplete.. that confused me for a moment too before I read your comments.
Comment 9 Tomás Cohen Arazi 2022-10-14 12:33:53 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!