Bug 31765 - Add 'page-section' to import patrons page
Summary: Add 'page-section' to import patrons page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-13 12:14 UTC by Martin Renvoize
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31765: Add page-section and bg-info classes to 'Notes' (1.96 KB, patch)
2022-10-22 08:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31765: Add page-section and bg-info classes to 'Notes' (1.96 KB, patch)
2022-10-23 12:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31765: Add page-section and bg-info classes to 'Notes' (2.01 KB, patch)
2022-10-23 12:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-13 12:14:34 UTC
I think the 'Notes' section on the import patrons page needs either page-section or a similar, but different background, class adding to distinguish the notes as 'info only'
Comment 1 Martin Renvoize 2022-10-22 08:23:01 UTC
Created attachment 142449 [details] [review]
Bug 31765: Add page-section and bg-info classes to 'Notes'

This patch adds the page-section and bg-info classes to the 'Notes'
section of the patron imports page.

As part of this patch, we update the base 'card' mixin to allow
background colors to be overwridden with the standard bg-* options
available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/)

Test plan
1) Build your CSS in the usual way
2) Confirm the Notes block looks OK on the patron imports tool
Comment 2 Katrin Fischer 2022-10-23 12:42:09 UTC
Created attachment 142461 [details] [review]
Bug 31765: Add page-section and bg-info classes to 'Notes'

This patch adds the page-section and bg-info classes to the 'Notes'
section of the patron imports page.

As part of this patch, we update the base 'card' mixin to allow
background colors to be overwridden with the standard bg-* options
available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/)

Test plan
1) Build your CSS in the usual way
2) Confirm the Notes block looks OK on the patron imports tool
Comment 3 Katrin Fischer 2022-10-23 12:44:08 UTC
Created attachment 142462 [details] [review]
Bug 31765: Add page-section and bg-info classes to 'Notes'

This patch adds the page-section and bg-info classes to the 'Notes'
section of the patron imports page.

As part of this patch, we update the base 'card' mixin to allow
background colors to be overwridden with the standard bg-* options
available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/)

Test plan
1) Build your CSS in the usual way
2) Confirm the Notes block looks OK on the patron imports tool

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-10-23 12:44:34 UTC
Moving this directly on to Tomas.
Comment 5 Tomás Cohen Arazi 2022-10-24 13:58:16 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!