Bug 31774 - Add 'page-section' to Manage staged MARC records page
Summary: Add 'page-section' to Manage staged MARC records page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Martin Renvoize
URL:
Keywords: Academy
: 32234 (view as bug list)
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-13 12:35 UTC by Martin Renvoize
Modified: 2023-06-08 22:28 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31774: Add 'page-section' to list of imported records (1.56 KB, patch)
2022-11-16 19:14 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31774: Add 'page-section' to list of imported records (1.62 KB, patch)
2022-11-17 11:31 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 31774: Add 'page-section' to list of imported records (1.68 KB, patch)
2022-11-17 14:29 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 31774: Add 'page-section' to list of imported records (1.68 KB, patch)
2022-11-17 14:58 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-13 12:35:03 UTC
We need the page-section div adding to Manage staged MARC records page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Martin Renvoize 2022-11-15 22:21:28 UTC
The main page has a page-section now, but once you click through to a staged set the results table at the bottom of the page is not contained within such a div yet.
Comment 2 Katrin Fischer 2022-11-16 19:10:16 UTC
Stealing this one from Martin...
Comment 3 Katrin Fischer 2022-11-16 19:14:42 UTC
Created attachment 143968 [details] [review]
Bug 31774: Add 'page-section' to list of imported records

To test:
* Stage a MARC file with a few records
* Look at the import results
* The list of imported records doesn't have the white
  page section background
* Apply patch
* Refresh page and verify the table now is contained
Comment 4 Martin Renvoize 2022-11-16 19:17:27 UTC
Nice one Katrin, thought I might get to this one today with one of the new team but we didn't manage it so happy to see it stolen.. plenty more out there 😁

I'll get them to practice a signoff instead
Comment 5 PTFS Europe Sandboxes 2022-11-17 11:31:35 UTC
Created attachment 143993 [details] [review]
Bug 31774: Add 'page-section' to list of imported records

To test:
* Stage a MARC file with a few records
* Look at the import results
* The list of imported records doesn't have the white
  page section background
* Apply patch
* Refresh page and verify the table now is contained

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 PTFS Europe Sandboxes 2022-11-17 14:29:57 UTC
Created attachment 144002 [details] [review]
Bug 31774: Add 'page-section' to list of imported records

To test:
* Stage a MARC file with a few records
* Look at the import results
* The list of imported records doesn't have the white
  page section background
* Apply patch
* Refresh page and verify the table now is contained

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2022-11-17 14:34:21 UTC
Using this bug to work on sandboxes for a few minutes.. trying to get signoffs using the form input
Comment 8 Martin Renvoize 2022-11-17 14:58:22 UTC
Created attachment 144004 [details] [review]
Bug 31774: Add 'page-section' to list of imported records

To test:
* Stage a MARC file with a few records
* Look at the import results
* The list of imported records doesn't have the white
  page section background
* Apply patch
* Refresh page and verify the table now is contained

Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2022-11-17 14:59:41 UTC
I've sorted out the SO line to catch Jacob (one of our new devs) who actually tested and signed off on the bug on a sandbox during training today.

Will keep bashing at fixing the sandboxes.

Passing QA on the patch itself.. trivial and solid fix.
Comment 10 Tomás Cohen Arazi 2022-11-17 16:42:51 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 11 Owen Leonard 2022-11-17 19:41:00 UTC
*** Bug 32234 has been marked as a duplicate of this bug. ***