Bug 31776 - Typo in cleanup_database.pl cron's help/usage
Summary: Typo in cleanup_database.pl cron's help/usage
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Peter Vashchuk
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-13 14:37 UTC by Peter Vashchuk
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15


Attachments
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage (1.30 KB, patch)
2022-10-13 14:38 UTC, Peter Vashchuk
Details | Diff | Splinter Review
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage (1.35 KB, patch)
2022-10-13 20:37 UTC, David Nind
Details | Diff | Splinter Review
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage (1.41 KB, patch)
2022-10-15 08:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage (1.47 KB, patch)
2022-10-17 11:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Vashchuk 2022-10-13 14:37:09 UTC

    
Comment 1 Peter Vashchuk 2022-10-13 14:38:56 UTC
Created attachment 141826 [details] [review]
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage

cleanup_database.pl cronjob has a typo in it's usage/help:
"preserve-logs" option should be "preserve-log" as it is everywhere
in the code.
Comment 2 David Nind 2022-10-13 20:37:49 UTC
Created attachment 141844 [details] [review]
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage

cleanup_database.pl cronjob has a typo in it's usage/help:
"preserve-logs" option should be "preserve-log" as it is everywhere
in the code.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-10-13 20:42:20 UTC
Testing notes (using koha-testing-docker):

- Ran cronjob with --preserve-logs option and got error message:
  misc/cronjobs/cleanup_database.pl --preserve-logs
  Unknown option: preserve-logs

- Ran cronjob with --preserve-log option and got message "You did not specify any cleanup work for the script to do."

- Checked help after patch applied and help text is corrected (misc/cronjobs/cleanup_database.pl --help)
Comment 4 Katrin Fischer 2022-10-15 08:06:23 UTC
Created attachment 141917 [details] [review]
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage

cleanup_database.pl cronjob has a typo in it's usage/help:
"preserve-logs" option should be "preserve-log" as it is everywhere
in the code.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-10-15 08:07:13 UTC
Hi Petro, please don't forget to set Assignee!
Comment 6 Tomás Cohen Arazi 2022-10-17 11:14:13 UTC
Created attachment 141954 [details] [review]
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage

cleanup_database.pl cronjob has a typo in it's usage/help:
"preserve-logs" option should be "preserve-log" as it is everywhere
in the code.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi 2022-10-17 11:29:09 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass 2022-12-05 20:29:56 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 9 Arthur Suzuki 2022-12-16 13:29:12 UTC
applied to 21.11 for 21.11.15
Comment 10 wainuiwitikapark 2023-03-15 00:56:56 UTC
Not backported to 21.05.x