Bug 31780 - Add 'page-section' to audio alerts ( audio_alerts.tt )
Summary: Add 'page-section' to audio alerts ( audio_alerts.tt )
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-13 19:56 UTC by Lucas Gass
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31780: Add page-section class to audio alerts (6.73 KB, patch)
2022-10-13 19:59 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31780: Add page-section class to audio alerts (6.78 KB, patch)
2022-10-13 21:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 31780: Add page-section class to audio alerts (6.84 KB, patch)
2022-10-14 14:51 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-10-13 19:56:02 UTC
We need the page-section div adding to audio alerts page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Lucas Gass 2022-10-13 19:59:47 UTC
Created attachment 141841 [details] [review]
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class added.

Note: There are some indentation changes.
Comment 2 David Nind 2022-10-13 21:39:07 UTC
Created attachment 141847 [details] [review]
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class added.

Note: There are some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2022-10-14 14:51:29 UTC
Created attachment 141893 [details] [review]
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class added.

Note: There are some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-10-14 15:02:23 UTC
Great work.. 

I wonder if the 'alert' div should be moved above the page heading and toolbar.. I've mentioned of irc we need a guideline for that.. alert box positions is another wildly inconsistent thing in Koha.
Comment 5 Tomás Cohen Arazi 2022-10-17 11:29:15 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!