Created attachment 144830 [details] [review] Bug 31800: Add REST endpoint to add a biblio To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Make a POST request to /api/v1/biblios with one of the following content type header - application/json - application/marcxml+xml - application/marc-in-json - application/marc 4. If content type is other than application/json, then add the following header to the request: "x-framework-id: <framework id>" 5. Check that the biblio is created 6. Sign off
Created attachment 144835 [details] [review] Bug 31800: Add REST endpoint to add a biblio To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Make a POST request to /api/v1/biblios with one of the following content type header - application/marcxml+xml - application/marc-in-json - application/marc 4. Add the following header to the request: "x-framework-id: <framework id>" 5. Check that the biblio is created 6. Sign off
Created attachment 144837 [details] [review] Bug 31800: Add REST endpoint to add a biblio To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Make a POST request to /api/v1/biblios with one of the following content type header - application/marcxml+xml - application/marc-in-json - application/marc 4. Add the following header to the request: "x-framework-id: <framework id>" 5. Check that the biblio is created 6. Sign off
Created attachment 145509 [details] [review] Bug 31800: Add REST endpoint to add a biblio To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Make a POST request to /api/v1/biblios with one of the following content type header - application/marcxml+xml - application/marc-in-json - application/marc 4. Add the following header to the request: "x-framework-id: <framework id>" 5. Check that the biblio is created 6. Sign off Signed-off-by: Jan Kissig <jkissig@th-wildau.de>
Changed status to signed off - signed off by Jan Kissig on 2023-01-20.
Created attachment 147714 [details] [review] Bug 31800: Add REST endpoint to add a biblio To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Make a POST request to /api/v1/biblios with one of the following content type header - application/marcxml+xml - application/marc-in-json - application/marc 4. Add the following header to the request: "x-framework-id: <framework id>" 5. Check that the biblio is created 6. Sign off Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
swagger-cli validate swagger.yaml: Validation failed. /paths/biblios/post/parameters/Body has an invalid type (string,object)
(In reply to Pedro Amorim from comment #8) > swagger-cli validate swagger.yaml: > > Validation failed. /paths/biblios/post/parameters/Body has an invalid type > (string,object) Can you file a separate bug for this? It is time to add the validation to the test suite.
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
The backport here causes test failures, (git auto-merged more than expected into the spec). I also feel like we need to get the whole tree working as a set before we consider a possible backport of this.. whilst it's API and thus Dev facing only really and might make sense to backport at a future point.. I think we need to focus on stability in this area first. Reverting for now.
OK.. Ignore that.. Whilst I still think it was a mistake to backport at this stage.. it's also a challenge to revert now too... we'll be most stable by keeping it
*** Bug 28201 has been marked as a duplicate of this bug. ***