Bug 31812 - Add yellow button to stage imports page
Summary: Add yellow button to stage imports page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31947
  Show dependency treegraph
 
Reported: 2022-10-15 08:14 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31812: Update 'Stage for import' button to be primary (1.08 KB, patch)
2022-10-24 14:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31812: Update 'Stage for import' button to be primary (1.14 KB, patch)
2022-10-24 17:57 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31812: Update 'Stage for import' button to be primary (1.19 KB, patch)
2022-10-24 18:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-15 08:14:49 UTC
As I undertand, the main action on a page should have a yellow button - no yellow buttons on the manage staged imports page.
Comment 1 Fridolin Somers 2022-10-20 08:38:56 UTC
You mean /cgi-bin/koha/tools/manage-marc-import.pl ?
I only see a table, there is no main action I think.

On a batch /cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1
I see 2 input type=submit already yellow
Comment 2 Katrin Fischer 2022-10-22 09:51:00 UTC
i meant one step earlier, when you stage:

* Upload file
* Stage for import
Comment 3 Katrin Fischer 2022-10-22 09:52:24 UTC
Possibly really meant something else when first filing this, but this looks good now.
Comment 4 Martin Renvoize 2022-10-24 14:04:26 UTC
Created attachment 142512 [details] [review]
Bug 31812: Update 'Stage for import' button to be primary

This patch updates the 'Stage for import' input to be of type="submit"
and classes is a "button".. This gives it the yellow main action
hinting.
Comment 5 Lucas Gass 2022-10-24 17:57:38 UTC
Created attachment 142541 [details] [review]
Bug 31812: Update 'Stage for import' button to be primary

This patch updates the 'Stage for import' input to be of type="submit"
and classes is a "button".. This gives it the yellow main action
hinting.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Katrin Fischer 2022-10-24 18:02:20 UTC
Created attachment 142542 [details] [review]
Bug 31812: Update 'Stage for import' button to be primary

This patch updates the 'Stage for import' input to be of type="submit"
and classes is a "button".. This gives it the yellow main action
hinting.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-10-24 18:02:50 UTC
I feel like the upload file button should be yellow too, as we only see this one at first, what do you think?
Comment 8 Tomás Cohen Arazi 2022-10-24 18:44:46 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Martin Renvoize 2022-10-25 11:10:54 UTC
(In reply to Katrin Fischer from comment #7)
> I feel like the upload file button should be yellow too, as we only see this
> one at first, what do you think?

Looks like this was missed before push?

Perhaps a new bug so we don't lose it?
Comment 10 Owen Leonard 2022-11-15 12:20:10 UTC
(In reply to Martin Renvoize from comment #9)
> (In reply to Katrin Fischer from comment #7)
> > I feel like the upload file button should be yellow too, as we only see this
> > one at first, what do you think?

Fixed by Bug 32096: Consistent classes for primary buttons: Tools