Bug 31823 - Add page-section to uncertain prices page (acq)
Summary: Add page-section to uncertain prices page (acq)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-16 11:16 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31823: Add page-section to uncertain prices page (acq) (12.74 KB, patch)
2022-11-09 16:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31823: Add page-section to uncertain prices page (acq) (12.79 KB, patch)
2022-11-09 20:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 31823: Add page-section to uncertain prices page (acq) (12.85 KB, patch)
2022-11-09 23:20 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 11:16:42 UTC
Might need one or 2 classes added for the information on top and the list of orders with uncertain prices.
Comment 1 Owen Leonard 2022-11-09 16:18:41 UTC
Created attachment 143521 [details] [review]
Bug 31823: Add page-section to uncertain prices page (acq)

This patch adds a "page-section" wrapping div to the uncertain prices
page in Acquisitions

Note: This patch contains indentation changes.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details
- In the left-hand sidebar, click "Uncertain prices."
- The page should have two sections: Details about the vendor, and a
  list of orders with uncertain prices.
Comment 2 David Nind 2022-11-09 20:48:12 UTC
Created attachment 143588 [details] [review]
Bug 31823: Add page-section to uncertain prices page (acq)

This patch adds a "page-section" wrapping div to the uncertain prices
page in Acquisitions

Note: This patch contains indentation changes.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details
- In the left-hand sidebar, click "Uncertain prices."
- The page should have two sections: Details about the vendor, and a
  list of orders with uncertain prices.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-09 23:20:42 UTC
Created attachment 143600 [details] [review]
Bug 31823: Add page-section to uncertain prices page (acq)

This patch adds a "page-section" wrapping div to the uncertain prices
page in Acquisitions

Note: This patch contains indentation changes.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details
- In the left-hand sidebar, click "Uncertain prices."
- The page should have two sections: Details about the vendor, and a
  list of orders with uncertain prices.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-10 13:05:54 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!