Bug 31824 - Add page-section to list of pending/received orders (acq)
Summary: Add page-section to list of pending/received orders (acq)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/acqui/parcel.pl?invoice...
Keywords:
: 31820 (view as bug list)
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-16 11:20 UTC by Katrin Fischer
Modified: 2023-06-08 22:29 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31824: Add page-section to list of pending/received orders (acq) (1.76 KB, patch)
2022-11-09 16:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31824: Add page-section to list of pending/received orders (acq) (1.80 KB, patch)
2022-11-09 20:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 31824: Add page-section to list of pending/received orders (acq) (1.86 KB, patch)
2022-11-09 23:22 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 11:20:35 UTC
When receiving a shipment, the list of pending and then received orders (table below the first one) requires the treatment with page-section classes.
Comment 1 Owen Leonard 2022-11-09 16:49:27 UTC
Created attachment 143557 [details] [review]
Bug 31824: Add page-section to list of pending/received orders (acq)

This patch adds a "page-section" class to the divs wrapping two
sections on the "Receive orders" page in Acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- If you have existing shipments listed in the first section, click the
  invoice number link.
  - If not, fill out the "receive a new shipment" form and submit it.
- On the "Receive orders" page there should be two sections: "Pending
  orders" and "Already received."
Comment 2 Owen Leonard 2022-11-09 16:52:37 UTC
*** Bug 31820 has been marked as a duplicate of this bug. ***
Comment 3 David Nind 2022-11-09 20:51:51 UTC
Created attachment 143589 [details] [review]
Bug 31824: Add page-section to list of pending/received orders (acq)

This patch adds a "page-section" class to the divs wrapping two
sections on the "Receive orders" page in Acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- If you have existing shipments listed in the first section, click the
  invoice number link.
  - If not, fill out the "receive a new shipment" form and submit it.
- On the "Receive orders" page there should be two sections: "Pending
  orders" and "Already received."

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2022-11-09 23:22:45 UTC
Created attachment 143601 [details] [review]
Bug 31824: Add page-section to list of pending/received orders (acq)

This patch adds a "page-section" class to the divs wrapping two
sections on the "Receive orders" page in Acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- If you have existing shipments listed in the first section, click the
  invoice number link.
  - If not, fill out the "receive a new shipment" form and submit it.
- On the "Receive orders" page there should be two sections: "Pending
  orders" and "Already received."

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-10 13:06:01 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!