Bug 31828 - Add page-section to list of open invoices on receive shipment page (acq)
Summary: Add page-section to list of open invoices on receive shipment page (acq)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/acqui/parcels.pl?bookse...
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-16 11:39 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31828: Add page-section to list of open invoices on receive shipment page (acq) (2.39 KB, patch)
2022-11-09 16:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31828: Add page-section to list of open invoices on receive shipment page (acq) (2.43 KB, patch)
2022-11-09 21:12 UTC, David Nind
Details | Diff | Splinter Review
Bug 31828: Add page-section to list of open invoices on receive shipment page (acq) (2.49 KB, patch)
2022-11-09 23:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 11:39:08 UTC
When receiving a shipment and you have existing open invoices for this vendor, they show in a list above the form for entering the new invoice number. This area needs a page-section.
Comment 1 Owen Leonard 2022-11-09 16:36:03 UTC
Created attachment 143524 [details] [review]
Bug 31828: Add page-section to list of open invoices on receive shipment page (acq)

This patch adds a "page-section" class to the div wrapping the table
of shipments on the "Receive shipment" page in Acquisitions.

This patch also modifies the markup around additional fields so that an
empty fieldset is not displayed when there are no additional fields to
display.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- On the receive page, there should be a section listing shipments and a
  section headed "Receive a new shipment."
- If you have additional fields defined (in Administration -> Additional
  fields -> Invoices) there should be a third section showing those
  fields.
- With no additional fields defined you should not see an empty
  fieldset.
Comment 2 David Nind 2022-11-09 21:12:53 UTC
Created attachment 143593 [details] [review]
Bug 31828: Add page-section to list of open invoices on receive shipment page (acq)

This patch adds a "page-section" class to the div wrapping the table
of shipments on the "Receive shipment" page in Acquisitions.

This patch also modifies the markup around additional fields so that an
empty fieldset is not displayed when there are no additional fields to
display.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- On the receive page, there should be a section listing shipments and a
  section headed "Receive a new shipment."
- If you have additional fields defined (in Administration -> Additional
  fields -> Invoices) there should be a third section showing those
  fields.
- With no additional fields defined you should not see an empty
  fieldset.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-09 23:38:45 UTC
Created attachment 143604 [details] [review]
Bug 31828: Add page-section to list of open invoices on receive shipment page (acq)

This patch adds a "page-section" class to the div wrapping the table
of shipments on the "Receive shipment" page in Acquisitions.

This patch also modifies the markup around additional fields so that an
empty fieldset is not displayed when there are no additional fields to
display.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- On the receive page, there should be a section listing shipments and a
  section headed "Receive a new shipment."
- If you have additional fields defined (in Administration -> Additional
  fields -> Invoices) there should be a third section showing those
  fields.
- With no additional fields defined you should not see an empty
  fieldset.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-10 13:06:20 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!