Bug 31834 - Inconsistent table formatting for list of MARC imports
Summary: Inconsistent table formatting for list of MARC imports
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31833
  Show dependency treegraph
 
Reported: 2022-10-16 12:31 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31834: Replace incorrect "table" class from MARC imports table (12.01 KB, patch)
2022-10-24 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31834: Replace incorrect "table" class from MARC imports table (12.06 KB, patch)
2022-10-24 18:34 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31834: Replace incorrect "table" class from MARC imports table (12.12 KB, patch)
2022-10-24 19:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 12:31:31 UTC
The table has a line on top of the header line, which is inconsistent with other pages.
Comment 1 Owen Leonard 2022-10-24 14:27:59 UTC
Created attachment 142515 [details] [review]
Bug 31834: Replace incorrect "table" class from MARC imports table

The table containing staged MARC record batches has a "table" class
added to the <table> tag, which is inconsistent with other tables in the
staff interface. The class pulls in default table styles from Bootstrap
which aren't consistent.

There are a few other non-DataTable tables have the the class
"dataTable" added in order to make them more consistent. I think this
table should have that class too. The template is also modified to give
the table a <thead> and <tbody>, with indentation corrected accordingly.

To test, apply the patch and go to Cataloging -> Manage staged records.

The table of staged records should look correct, with style matching
DataTables elsewhere in Koha, e.g. Administration -> Libraries.
Comment 2 Lucas Gass 2022-10-24 18:34:15 UTC
Looks better, and all the HTML is valid. My apologies as I think I was the one to add that 'table' class.
Comment 3 Lucas Gass 2022-10-24 18:34:58 UTC
Created attachment 142550 [details] [review]
Bug 31834: Replace incorrect "table" class from MARC imports table

The table containing staged MARC record batches has a "table" class
added to the <table> tag, which is inconsistent with other tables in the
staff interface. The class pulls in default table styles from Bootstrap
which aren't consistent.

There are a few other non-DataTable tables have the the class
"dataTable" added in order to make them more consistent. I think this
table should have that class too. The template is also modified to give
the table a <thead> and <tbody>, with indentation corrected accordingly.

To test, apply the patch and go to Cataloging -> Manage staged records.

The table of staged records should look correct, with style matching
DataTables elsewhere in Koha, e.g. Administration -> Libraries.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2022-10-24 19:18:31 UTC
Created attachment 142554 [details] [review]
Bug 31834: Replace incorrect "table" class from MARC imports table

The table containing staged MARC record batches has a "table" class
added to the <table> tag, which is inconsistent with other tables in the
staff interface. The class pulls in default table styles from Bootstrap
which aren't consistent.

There are a few other non-DataTable tables have the the class
"dataTable" added in order to make them more consistent. I think this
table should have that class too. The template is also modified to give
the table a <thead> and <tbody>, with indentation corrected accordingly.

To test, apply the patch and go to Cataloging -> Manage staged records.

The table of staged records should look correct, with style matching
DataTables elsewhere in Koha, e.g. Administration -> Libraries.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-10-24 20:23:18 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!