Bug 31835 - Add page-section to holds queue
Summary: Add page-section to holds queue
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL: /cgi-bin/koha/circ/view_holdsqueue.pl
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-16 13:29 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31835: Add page-section to holds queue (15.49 KB, patch)
2022-10-17 17:26 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31835: Add page-section to holds queue (15.55 KB, patch)
2022-10-17 19:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 13:29:35 UTC
The table on the holds queue page needs to be a page-section.
Comment 1 Lucas Gass 2022-10-17 17:26:21 UTC
Created attachment 142002 [details] [review]
Bug 31835: Add page-section to holds queue

To test:
1. Apply patch
2. Make some holds and then run build_holds_queue.pl
3. Look at the holds queue and make sure everything looks right with the new page-section.

Note:
I made some indentation and whitespace changes.
Comment 2 Katrin Fischer 2022-10-17 19:53:43 UTC
Created attachment 142023 [details] [review]
Bug 31835: Add page-section to holds queue

To test:
1. Apply patch
2. Make some holds and then run build_holds_queue.pl
3. Look at the holds queue and make sure everything looks right with the new page-section.

Note:
I made some indentation and whitespace changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2022-10-17 19:54:46 UTC
Small change, expecting a lot more of these soon. Going straight to PQA.
Comment 4 Tomás Cohen Arazi 2022-10-17 21:10:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!