Bug 3184 - Show creator and budget receiving a document
Summary: Show creator and budget receiving a document
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.6
Hardware: All All
: P4 enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-04 02:51 UTC by Nahuel Angelinetti
Modified: 2012-10-25 23:09 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
bugfix for 3.0.x (2.72 KB, patch)
2009-05-04 14:52 UTC, Chris Cormack
Details | Diff | Splinter Review
receive page without user and budget (87.71 KB, image/png)
2009-12-17 01:45 UTC, Chris Cormack
Details
screenshot of receive page (40.84 KB, image/png)
2011-08-15 18:17 UTC, Katrin Fischer
Details
screenshot of order receive page with creator name and fund (20.63 KB, image/png)
2011-10-28 13:53 UTC, Katrin Fischer
Details
Bug 3184: Show creator and budget on order receive page (3.71 KB, patch)
2011-10-28 14:00 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 3184: Show creator and budget on order receive page (3.88 KB, patch)
2011-10-28 16:51 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 3184: Show creator and budget on order receive page (3.98 KB, patch)
2011-11-27 18:28 UTC, Katrin Fischer
Details | Diff | Splinter Review
Signed off patch (4.04 KB, patch)
2011-12-13 23:46 UTC, Duncan
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:07:26 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2009-05-04 14:51:29 ----

When the user is receiving a shipment, the basket creator name, and the budget should be shown.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-05-04 14:52:45 ----

Created an attachment
bugfix for 3.0.x





---- Additional Comments From nengard@gmail.com 2009-12-17 01:45:37 ----

Created an attachment
receive page without user and budget

The receive page shows the basket number but not the person who placed the order or the budget in use.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:07 UTC  ---

This bug was previously known as _bug_ 3184 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3184
Imported an attachment (id=1151)
Imported an attachment (id=1152)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1151 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1152 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Katrin Fischer 2011-08-15 18:17:22 UTC
I can't find the patch in current master and I see no information about basket creator or budget on the receive page.

Changing version as 3.0.x is no longer maintained.
Attached patch is still for 3.2.x and probably needs to reimplemented.
Comment 2 Katrin Fischer 2011-08-15 18:17:45 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2011-10-28 13:53:45 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2011-10-28 14:00:33 UTC Comment hidden (obsolete)
Comment 5 Liz Rea 2011-10-28 16:51:47 UTC Comment hidden (obsolete)
Comment 6 Ian Walls 2011-11-19 15:49:07 UTC
This patch falls victim to the same issue as bug 6390:  there is no way to ensure that authorisedby is a value borrowernumber.  The borrower could have been deleted, or if the koha database user account was used, then there would be no GetMember record to view.  This will lead to the "Can't use an undefined value as a HASH reference" error, breaking the page.

Please provide a fall-back value for the $member hash in the event the authorisedby value is not a valid borrowernumber.
Comment 7 Katrin Fischer 2011-11-27 18:28:20 UTC Comment hidden (obsolete)
Comment 8 Duncan 2011-12-13 23:46:25 UTC
Created attachment 6763 [details] [review]
Signed off patch
Comment 9 Ian Walls 2012-01-04 13:32:27 UTC
Fetches borrower using 'authorisedby', which will not always work.  Thankfully, default values are provided for firstname and surname, so in the event of a deleted borrower, this shouldn't cause problems.

Other than recommending a note above the GetMember line to document the above, I have no other recommendations for this patch.  Marking Passed QA.
Comment 10 Paul Poulain 2012-01-06 12:27:53 UTC
Patch pushed, please test

QA comment:
checked perlcritic & valid template are still OK:
perlcritic acqui/orderreceive.pl
acqui/orderreceive.pl source OK
prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok