delete_patrons.pl has this option: --not_borrowed_since Delete patrons who have not borrowed since this date. This sounds easy enough, but if you have patrons with borrowers.privacy = 2, they will have their issues/loans anonymized as they are returned, resulting in an empty history, and they will be deleted the next time delete_patrons.pl is run, even if they have just been active. This is not a problem in itself, but a reminder could be added to the documentation for --not_borrowed_since, to avoid patrons being unduly deleted.
There could be more reasons for anonymization than borrowers.privacy = 2. Also: - borrowers.privacy = 1 + misc/cronjobs/batch_anonymise.pl - patrons choosing to anonymize their history in the OPAC
Created attachment 142055 [details] [review] Bug 31854: Document --not_borrowed_since and anonymization To test: - Run "perldoc misc/cronjobs/delete_patrons.pl" - Note the absence of information about the potential conflict between --not_borrowed_since and anonymization - Apply this patch - Re-run the perldoc command and make sure the note about anonymization make sense
Created attachment 142849 [details] [review] Bug 31854: Document --not_borrowed_since and anonymization To test: - Run "perldoc misc/cronjobs/delete_patrons.pl" - Note the absence of information about the potential conflict between --not_borrowed_since and anonymization - Apply this patch - Re-run the perldoc command and make sure the note about anonymization make sense Signed-off-by: David Nind <david@davidnind.com>
Updated the assignee...
Created attachment 143027 [details] [review] Bug 31854: Document --not_borrowed_since and anonymization To test: - Run "perldoc misc/cronjobs/delete_patrons.pl" - Note the absence of information about the potential conflict between --not_borrowed_since and anonymization - Apply this patch - Re-run the perldoc command and make sure the note about anonymization make sense Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 143028 [details] [review] Bug 31854: (QA follow-up) Terminology: loans > checkouts
Pushed to master for 22.11. Nice work everyone, thanks!