Bug 31870 - Cleaning up t/db_dependent/Context.t
Summary: Cleaning up t/db_dependent/Context.t
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-19 11:42 UTC by Marcel de Rooy
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31870: Groundwork for Context.t (3.04 KB, patch)
2022-10-19 12:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31870: Context.t: Fix indentation, remove old comments (11.07 KB, patch)
2022-10-19 12:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31870: Context.t: Reorganize subtests (3.91 KB, patch)
2022-10-19 12:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31870: Add license, remove unused modules (1.72 KB, patch)
2022-10-19 12:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31870: Groundwork for Context.t (3.05 KB, patch)
2022-10-22 10:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31870: Context.t: Fix indentation, remove old comments (11.09 KB, patch)
2022-10-22 10:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31870: Context.t: Reorganize subtests (3.92 KB, patch)
2022-10-22 10:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31870: Add license, remove unused modules (1.74 KB, patch)
2022-10-22 10:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-10-19 11:42:10 UTC

    
Comment 1 Marcel de Rooy 2022-10-19 12:17:57 UTC
Moving some work here that I intended to go with a rework of 31784.
Comment 2 Marcel de Rooy 2022-10-19 12:19:18 UTC
Created attachment 142149 [details] [review]
Bug 31870: Groundwork for Context.t

Replacing the vars statement.
Adding a larger subtest.
Removing TransformVersionToNum.

Test plan:
Run t/db_dependent/Context.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2022-10-19 12:19:22 UTC
Created attachment 142150 [details] [review]
Bug 31870: Context.t: Fix indentation, remove old comments

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2022-10-19 12:19:25 UTC
Created attachment 142151 [details] [review]
Bug 31870: Context.t: Reorganize subtests

Move a few tests into separate subtests.
Replace the BEGIN block.

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2022-10-19 12:19:29 UTC
Created attachment 142152 [details] [review]
Bug 31870: Add license, remove unused modules

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2022-10-19 12:20:03 UTC
Architectural + trivial, self SO
Comment 7 Katrin Fischer 2022-10-22 10:10:43 UTC
Created attachment 142453 [details] [review]
Bug 31870: Groundwork for Context.t

Replacing the vars statement.
Adding a larger subtest.
Removing TransformVersionToNum.

Test plan:
Run t/db_dependent/Context.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2022-10-22 10:10:48 UTC
Created attachment 142454 [details] [review]
Bug 31870: Context.t: Fix indentation, remove old comments

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2022-10-22 10:10:53 UTC
Created attachment 142455 [details] [review]
Bug 31870: Context.t: Reorganize subtests

Move a few tests into separate subtests.
Replace the BEGIN block.

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2022-10-22 10:10:57 UTC
Created attachment 142456 [details] [review]
Bug 31870: Add license, remove unused modules

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Tomás Cohen Arazi 2022-10-24 14:46:05 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 12 Lucas Gass 2022-12-05 21:42:20 UTC
Enhancement won't be backported to 22.05.x series