Bug 31877 - Capitalization: Delete this Tag and Repeat this Tag
Summary: Capitalization: Delete this Tag and Repeat this Tag
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Martin Renvoize
URL:
Keywords: Academy
: 31878 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-10-19 16:19 UTC by Caroline Cyr La Rose
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag" (6.18 KB, patch)
2022-10-24 20:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag" (6.25 KB, patch)
2022-10-24 21:19 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag" (6.31 KB, patch)
2022-11-02 14:04 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-10-19 16:19:16 UTC
The string "Delete this Tag" appears in addbiblio.tt a couple of times. It should be "Delete this tag".

To get to the string in the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title)
   --> a little popup thing (tooltip?) appears with "Delete this Tag"
4. Open the developper tools inspector in your browser
5. Click on the delete tag button
   --> the image alt text is "Delete this Tag"
Comment 1 Katrin Fischer 2022-10-24 20:41:06 UTC
*** Bug 31878 has been marked as a duplicate of this bug. ***
Comment 2 Katrin Fischer 2022-10-24 20:44:36 UTC
To get to the string in the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the duplicate tag buttons (two rectangles next to the tag title, e.g. next to 020 in MARC21)
   --> a little popup thing (tooltip?) appears with "Repeat this Tag"
4. Open the developper tools inspector in your browser
5. Click on the duplicate tag button
   --> the image alt text is "Repeat this Tag"
Comment 3 Katrin Fischer 2022-10-24 20:52:13 UTC
Created attachment 142569 [details] [review]
Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag"

To get to the string in the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title)
   --> a little popup thing (tooltip?) appears with "Delete this Tag"
4. Open the developper tools inspector in your browser
5. Click on the delete tag button
   --> the image alt text is "Delete this Tag"
6. Repeat the same check in the authorities editor
7. Apply patch
8. All tooltips and alt text should read correctly now
Comment 4 Caroline Cyr La Rose 2022-10-24 21:19:18 UTC
Created attachment 142572 [details] [review]
Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag"

To get to the string in the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title)
   --> a little popup thing (tooltip?) appears with "Delete this Tag"
4. Open the developper tools inspector in your browser
5. Click on the delete tag button
   --> the image alt text is "Delete this Tag"
6. Repeat the same check in the authorities editor
7. Apply patch
8. All tooltips and alt text should read correctly now

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 5 Martin Renvoize 2022-11-02 14:04:55 UTC
Created attachment 142978 [details] [review]
Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag"

To get to the string in the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title)
   --> a little popup thing (tooltip?) appears with "Delete this Tag"
4. Open the developper tools inspector in your browser
5. Click on the delete tag button
   --> the image alt text is "Delete this Tag"
6. Repeat the same check in the authorities editor
7. Apply patch
8. All tooltips and alt text should read correctly now

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2022-11-02 14:05:51 UTC
Ha.. there's another bug for the other case.

Passing QA.. this works great.. especially when bug 31876 is also included :)
Comment 7 Tomás Cohen Arazi 2022-11-02 22:27:52 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!