Now that we are making more use of SCSS variables it would be efficient to be able to use them in mainpage.css where some common colors are specified. Plus any additional auto-minification we can do is helpful.
Created attachment 142199 [details] [review] Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed.
Created attachment 142203 [details] [review] Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using koha-testing-docker): - Added a purchase suggestion to show the pending area. - Added some text to IntranetmainUserblock system preference.
Created attachment 142458 [details] [review] Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!