Bug 31884 - In check in page submit button should be yellow
Summary: In check in page submit button should be yellow
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 31947
  Show dependency treegraph
 
Reported: 2022-10-20 06:20 UTC by Fridolin Somers
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31884: Define 'check in' button as primary (1.66 KB, patch)
2022-10-20 06:22 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 31884: Define 'check in' button as primary (1.71 KB, patch)
2022-10-20 07:55 UTC, David Nind
Details | Diff | Splinter Review
Bug 31884: Define 'check in' button as primary (1.76 KB, patch)
2022-10-20 15:20 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2022-10-20 06:20:11 UTC
Like Bug 31810, check in button in check in page is the most important action on this form, it should be yellow.
Comment 1 Fridolin Somers 2022-10-20 06:22:52 UTC
Created attachment 142225 [details] [review]
Bug 31884: Define 'check in' button as primary

Check in button in check in page is the most important action on this form, it should be yellow

Test plan :
1) Go to check in page /cgi-bin/koha/circ/returns.pl
2) Check submit button 'Check in' as class 'btn-primary' and is yellow
Comment 2 Fridolin Somers 2022-10-20 06:29:39 UTC
BTW maybe button text should be "Submit" like in renew page
Comment 3 David Nind 2022-10-20 07:55:58 UTC
Created attachment 142228 [details] [review]
Bug 31884: Define 'check in' button as primary

Check in button in check in page is the most important action on this form, it should be yellow

Test plan :
1) Go to check in page /cgi-bin/koha/circ/returns.pl
2) Check submit button 'Check in' as class 'btn-primary' and is yellow

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-10-20 08:19:21 UTC
(In reply to Fridolin Somers from comment #2)
> BTW maybe button text should be "Submit" like in renew page

I'm not sure what Koha's convention is, but I generally prefer a specific label/action rather than a generic submit.
Comment 5 Lucas Gass 2022-10-20 15:20:39 UTC
Created attachment 142261 [details] [review]
Bug 31884: Define 'check in' button as primary

Check in button in check in page is the most important action on this form, it should be yellow

Test plan :
1) Go to check in page /cgi-bin/koha/circ/returns.pl
2) Check submit button 'Check in' as class 'btn-primary' and is yellow

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2022-10-21 12:59:13 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!