Like Bug 31810, check in button in check in page is the most important action on this form, it should be yellow.
Created attachment 142225 [details] [review] Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow
BTW maybe button text should be "Submit" like in renew page
Created attachment 142228 [details] [review] Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow Signed-off-by: David Nind <david@davidnind.com>
(In reply to Fridolin Somers from comment #2) > BTW maybe button text should be "Submit" like in renew page I'm not sure what Koha's convention is, but I generally prefer a specific label/action rather than a generic submit.
Created attachment 142261 [details] [review] Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!