Bug 31886 - No side menu when searching for syspref
Summary: No side menu when searching for syspref
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31758
Blocks: 32065 31917
  Show dependency treegraph
 
Reported: 2022-10-20 07:21 UTC by Jonathan Druart
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31886: Fix no sidebar problem in system pref search (1.69 KB, patch)
2022-10-20 22:25 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31886: Fix no sidebar problem in system pref search (1.75 KB, patch)
2022-10-21 11:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31886: Fix no sidebar problem in system pref search (1.69 KB, patch)
2022-10-21 14:58 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31886: Fix no sidebar problem in system pref search (1.74 KB, patch)
2022-10-21 15:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31886: Fix no sidebar problem in system pref search (1.81 KB, patch)
2022-10-21 15:05 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-10-20 07:21:29 UTC
And also something weird at the bottom, see https://snipboard.io/PRgUln.jpg
Comment 1 Lucas Gass 2022-10-20 22:19:57 UTC
I think it is because of 'LINE.is_group_title'. And that has to do with how we format the .pref yaml files. This seems to happen when you search brings up i18n_l10n or serial system prefs. If we fix the YAML, I think we'll fix the problem.
Comment 2 Lucas Gass 2022-10-20 22:25:10 UTC
Created attachment 142289 [details] [review]
Bug 31886: Fix no sidebar problem in system pref search

To test:
1. Go to Adminstration and click on 'Global system preferences'
2. From the left side bar click 'I18N/L10N' and notice no sidebar.
3. Also try 'Serials', no sidebar
4. Apply patch, restart_all
5. Try 1 & 2 again and the sidebar should be restored
6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present.
Comment 3 Martin Renvoize 2022-10-21 11:36:29 UTC
Created attachment 142335 [details] [review]
Bug 31886: Fix no sidebar problem in system pref search

To test:
1. Go to Adminstration and click on 'Global system preferences'
2. From the left side bar click 'I18N/L10N' and notice no sidebar.
3. Also try 'Serials', no sidebar
4. Apply patch, restart_all
5. Try 1 & 2 again and the sidebar should be restored
6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-10-21 11:40:14 UTC
Well spotted Lucas... I wonder if instead of repeating the title we should pick a appropriate subsection group title instead.

Perhaps 'Global' or 'Features' or something like that..

So something like?

* Serials - Features
* I18N - Global
Comment 5 Martin Renvoize 2022-10-21 11:42:07 UTC
Side note... it feels a bit weird that the 'You search for: TERM' is an H2 to me.. it means we end up with 'H1 > H2 > H2' and it doesn't stand out very well.. I'd be tempted to switch it to a span of some sort with it's own slightly different formatting?
Comment 6 Lucas Gass 2022-10-21 14:32:04 UTC
(In reply to Martin Renvoize from comment #4)
> Well spotted Lucas... I wonder if instead of repeating the title we should
> pick a appropriate subsection group title instead.
> 
> Perhaps 'Global' or 'Features' or something like that..
> 
> So something like?
> 
> * Serials - Features
> * I18N - Global

This seems reasonable to me, I'll make that change.
Comment 7 Katrin Fischer 2022-10-21 14:52:01 UTC
Just moving out of queue until it bounces back with the follow-up :)
Comment 8 Lucas Gass 2022-10-21 14:58:24 UTC
Created attachment 142402 [details] [review]
Bug 31886: Fix no sidebar problem in system pref search

To test:
1. Go to Adminstration and click on 'Global system preferences'
2. From the left side bar click 'I18N/L10N' and notice no sidebar.
3. Also try 'Serials', no sidebar
4. Apply patch, restart_all
5. Try 1 & 2 again and the sidebar should be restored
6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present.
Comment 9 Katrin Fischer 2022-10-21 15:04:08 UTC
Created attachment 142405 [details] [review]
Bug 31886: Fix no sidebar problem in system pref search

To test:
1. Go to Adminstration and click on 'Global system preferences'
2. From the left side bar click 'I18N/L10N' and notice no sidebar.
3. Also try 'Serials', no sidebar
4. Apply patch, restart_all
5. Try 1 & 2 again and the sidebar should be restored
6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 10 Katrin Fischer 2022-10-21 15:05:10 UTC
Created attachment 142406 [details] [review]
Bug 31886: Fix no sidebar problem in system pref search

To test:
1. Go to Adminstration and click on 'Global system preferences'
2. From the left side bar click 'I18N/L10N' and notice no sidebar.
3. Also try 'Serials', no sidebar
4. Apply patch, restart_all
5. Try 1 & 2 again and the sidebar should be restored
6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 11 Tomás Cohen Arazi 2022-10-24 13:58:49 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 12 Victor Grousset/tuxayo 2022-10-30 02:47:49 UTC
It seems there is still some invalid YAML:
https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/consoleText

Weird that only one build fails about this.

Failing files touched by this ticket and bug 31952
Comment 13 Lucas Gass 2022-10-31 17:00:03 UTC
(In reply to Victor Grousset/tuxayo from comment #12)
> It seems there is still some invalid YAML:
> https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/
> consoleText
> 
> Weird that only one build fails about this.
> 
> Failing files touched by this ticket and bug 31952

Victor,

Should we file a new bug for this?
Comment 14 Victor Grousset/tuxayo 2022-11-02 01:59:41 UTC
Ok, I wasn't sure if a follow-up could be made in the existing tickets: Bug 32065